Title: [165662] trunk/Source/WebCore
- Revision
- 165662
- Author
- simon.fra...@apple.com
- Date
- 2014-03-14 16:44:04 -0700 (Fri, 14 Mar 2014)
Log Message
Release-assert if someone starts the WebThread in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=130270
<rdar://problem/16332380>
Reviewed by Sam Weinig.
If someone tries to start the WebThread in the WebProcess, assert,
even in release builds, because this should never happen.
* platform/ios/wak/WebCoreThread.mm:
(WebThreadEnable):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (165661 => 165662)
--- trunk/Source/WebCore/ChangeLog 2014-03-14 23:40:27 UTC (rev 165661)
+++ trunk/Source/WebCore/ChangeLog 2014-03-14 23:44:04 UTC (rev 165662)
@@ -1,3 +1,17 @@
+2014-03-14 Simon Fraser <simon.fra...@apple.com>
+
+ Release-assert if someone starts the WebThread in the WebProcess
+ https://bugs.webkit.org/show_bug.cgi?id=130270
+ <rdar://problem/16332380>
+
+ Reviewed by Sam Weinig.
+
+ If someone tries to start the WebThread in the WebProcess, assert,
+ even in release builds, because this should never happen.
+
+ * platform/ios/wak/WebCoreThread.mm:
+ (WebThreadEnable):
+
2014-03-14 Peter Molnar <pmolnar.u-sze...@partner.samsung.com>
Clean up unused externs from WebCore logging.
Modified: trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm (165661 => 165662)
--- trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm 2014-03-14 23:40:27 UTC (rev 165661)
+++ trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm 2014-03-14 23:44:04 UTC (rev 165662)
@@ -30,6 +30,7 @@
#import "JSDOMWindowBase.h"
#import "ThreadGlobalData.h"
+#import "RuntimeApplicationChecksIOS.h"
#import "WebCoreThreadInternal.h"
#import "WebCoreThreadMessage.h"
#import "WebCoreThreadRun.h"
@@ -1001,7 +1002,9 @@
void WebThreadEnable(void)
{
- static pthread_once_t initControl = PTHREAD_ONCE_INIT;
+ RELEASE_ASSERT_WITH_MESSAGE(!WebCore::applicationIsWebProcess(), "The WebProcess should never run a Web Thread");
+
+ static pthread_once_t initControl = PTHREAD_ONCE_INIT;
pthread_once(&initControl, StartWebThread);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
