Title: [165672] trunk/Source/WebCore
Revision
165672
Author
simon.fra...@apple.com
Date
2014-03-14 20:21:22 -0700 (Fri, 14 Mar 2014)

Log Message

Fix scrollperf logging
https://bugs.webkit.org/show_bug.cgi?id=130278
<rdar://problem/16320003>

Reviewed by Anders Carlsson.

r165493 broke scrollperf logging by adding in the scroll position
to the viewport rect, which used to be 0,0 based. Restore
the previous behavior.

* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::logExposedUnfilledArea):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (165671 => 165672)


--- trunk/Source/WebCore/ChangeLog	2014-03-15 03:16:37 UTC (rev 165671)
+++ trunk/Source/WebCore/ChangeLog	2014-03-15 03:21:22 UTC (rev 165672)
@@ -1,3 +1,18 @@
+2014-03-14  Simon Fraser  <simon.fra...@apple.com>
+
+        Fix scrollperf logging
+        https://bugs.webkit.org/show_bug.cgi?id=130278
+        <rdar://problem/16320003>
+
+        Reviewed by Anders Carlsson.
+        
+        r165493 broke scrollperf logging by adding in the scroll position
+        to the viewport rect, which used to be 0,0 based. Restore
+        the previous behavior.
+
+        * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
+        (WebCore::ScrollingTreeScrollingNodeMac::logExposedUnfilledArea):
+
 2014-03-14  Zalan Bujtas  <za...@apple.com>
 
         Subpixel rendering: border-radius painting falls back to rectangle at subpixel positions.

Modified: trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm (165671 => 165672)


--- trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm	2014-03-15 03:16:37 UTC (rev 165671)
+++ trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm	2014-03-15 03:21:22 UTC (rev 165672)
@@ -485,7 +485,7 @@
     }
 
     FloatPoint scrollPosition = this->scrollPosition();
-    FloatRect viewPortRect(scrollPosition, viewportSize());
+    FloatRect viewPortRect(FloatPoint(), viewportSize());
     unsigned unfilledArea = TileController::blankPixelCountForTiles(tiles, viewPortRect, IntPoint(-scrollPosition.x(), -scrollPosition.y()));
 
     if (unfilledArea || m_lastScrollHadUnfilledPixels)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to