Title: [166124] trunk/Source/WebCore
Revision
166124
Author
simon.fra...@apple.com
Date
2014-03-22 13:02:26 -0700 (Sat, 22 Mar 2014)

Log Message

Some #include hygiene in Node/Element etc
https://bugs.webkit.org/show_bug.cgi?id=130642

Reviewed by Geoffrey Garen.

Clean up various #includes.

* accessibility/AccessibilityObject.h:
* bindings/js/WebCoreTypedArrayController.h:
* dom/Element.h:
* dom/EventListenerMap.h:
* dom/EventTarget.h:
* dom/Node.h:
* rendering/RenderObject.h:
* rendering/svg/RenderSVGRoot.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (166123 => 166124)


--- trunk/Source/WebCore/ChangeLog	2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/ChangeLog	2014-03-22 20:02:26 UTC (rev 166124)
@@ -1,5 +1,23 @@
 2014-03-22  Simon Fraser  <simon.fra...@apple.com>
 
+        Some #include hygiene in Node/Element etc
+        https://bugs.webkit.org/show_bug.cgi?id=130642
+
+        Reviewed by Geoffrey Garen.
+
+        Clean up various #includes.
+
+        * accessibility/AccessibilityObject.h:
+        * bindings/js/WebCoreTypedArrayController.h:
+        * dom/Element.h:
+        * dom/EventListenerMap.h:
+        * dom/EventTarget.h:
+        * dom/Node.h:
+        * rendering/RenderObject.h:
+        * rendering/svg/RenderSVGRoot.h:
+
+2014-03-22  Simon Fraser  <simon.fra...@apple.com>
+
         FloatRect.h on iOS should not suck in a system header
         https://bugs.webkit.org/show_bug.cgi?id=130641
 

Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (166123 => 166124)


--- trunk/Source/WebCore/accessibility/AccessibilityObject.h	2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h	2014-03-22 20:02:26 UTC (rev 166124)
@@ -86,7 +86,6 @@
 class RenderObject;
 class RenderListItem;
 class ScrollableArea;
-class VisibleSelection;
 class Widget;
 
 typedef unsigned AXID;

Modified: trunk/Source/WebCore/bindings/js/WebCoreTypedArrayController.h (166123 => 166124)


--- trunk/Source/WebCore/bindings/js/WebCoreTypedArrayController.h	2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/bindings/js/WebCoreTypedArrayController.h	2014-03-22 20:02:26 UTC (rev 166124)
@@ -26,10 +26,13 @@
 #ifndef WebCoreTypedArrayController_h
 #define WebCoreTypedArrayController_h
 
-#include <heap/Weak.h>
 #include <runtime/JSGlobalObject.h>
 #include <runtime/TypedArrayController.h>
 
+namespace JSC {
+class WeakHandleOwner;
+}
+
 namespace WebCore {
 
 class WebCoreTypedArrayController : public JSC::TypedArrayController {

Modified: trunk/Source/WebCore/dom/Element.h (166123 => 166124)


--- trunk/Source/WebCore/dom/Element.h	2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/dom/Element.h	2014-03-22 20:02:26 UTC (rev 166124)
@@ -31,6 +31,7 @@
 #include "HTMLNames.h"
 #include "RegionOversetState.h"
 #include "ScrollTypes.h"
+#include "SimulatedClickOptions.h"
 #include "StyleResolveTree.h"
 
 namespace WebCore {

Modified: trunk/Source/WebCore/dom/EventListenerMap.h (166123 => 166124)


--- trunk/Source/WebCore/dom/EventListenerMap.h	2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/dom/EventListenerMap.h	2014-03-22 20:02:26 UTC (rev 166124)
@@ -36,7 +36,7 @@
 #include "RegisteredEventListener.h"
 #include <memory>
 #include <wtf/Forward.h>
-#include <wtf/text/AtomicStringHash.h>
+#include <wtf/text/AtomicString.h>
 
 namespace WebCore {
 

Modified: trunk/Source/WebCore/dom/EventTarget.h (166123 => 166124)


--- trunk/Source/WebCore/dom/EventTarget.h	2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/dom/EventTarget.h	2014-03-22 20:02:26 UTC (rev 166124)
@@ -38,10 +38,13 @@
 #include <memory>
 #include <wtf/Forward.h>
 #include <wtf/HashMap.h>
-#include <wtf/text/AtomicStringHash.h>
 
+namespace WTF {
+class AtomicString;
+}
+
 namespace WebCore {
-
+    
     class AudioNode;
     class AudioContext;
     class AudioTrackList;

Modified: trunk/Source/WebCore/dom/Node.h (166123 => 166124)


--- trunk/Source/WebCore/dom/Node.h	2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/dom/Node.h	2014-03-22 20:02:26 UTC (rev 166124)
@@ -32,18 +32,20 @@
 #include "MutationObserver.h"
 #include "RenderStyleConstants.h"
 #include "ScriptWrappable.h"
-#include "SimulatedClickOptions.h"
 #include "TreeScope.h"
 #include "TreeShared.h"
 #include <wtf/Forward.h>
 #include <wtf/ListHashSet.h>
-#include <wtf/text/AtomicString.h>
 
 namespace JSC {
-    class VM;
-    class SlotVisitor;
+class VM;
+class SlotVisitor;
 }
 
+namespace WTF {
+class AtomicString;
+}
+
 // This needs to be here because Document.h also depends on it.
 #define DUMP_NODE_STATISTICS 0
 

Modified: trunk/Source/WebCore/rendering/RenderObject.h (166123 => 166124)


--- trunk/Source/WebCore/rendering/RenderObject.h	2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/rendering/RenderObject.h	2014-03-22 20:02:26 UTC (rev 166124)
@@ -62,7 +62,6 @@
 class RenderTheme;
 class TransformState;
 class VisiblePosition;
-class RenderSVGResourceContainer;
 #if PLATFORM(IOS)
 class SelectionRect;
 #endif

Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h (166123 => 166124)


--- trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h	2014-03-22 19:42:03 UTC (rev 166123)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h	2014-03-22 20:02:26 UTC (rev 166124)
@@ -31,6 +31,7 @@
 namespace WebCore {
 
 class AffineTransform;
+class RenderSVGResourceContainer;
 class SVGSVGElement;
 
 class RenderSVGRoot final : public RenderReplaced {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to