Title: [166304] trunk/Source/WebCore
- Revision
- 166304
- Author
- jer.no...@apple.com
- Date
- 2014-03-26 11:37:44 -0700 (Wed, 26 Mar 2014)
Log Message
REGRESSION(r162679): Poster image visible under the video
https://bugs.webkit.org/show_bug.cgi?id=130783
Reviewed by Simon Fraser.
In the listed revision, we started checking for isRenderImage()
instead of isImage(). RenderMedias return 'true' for the first
but 'false' for the second. Change the if() statement to check
for isRenderMedia() in addition to !isRenderImage().
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (166303 => 166304)
--- trunk/Source/WebCore/ChangeLog 2014-03-26 18:35:55 UTC (rev 166303)
+++ trunk/Source/WebCore/ChangeLog 2014-03-26 18:37:44 UTC (rev 166304)
@@ -1,3 +1,18 @@
+2014-03-26 Jer Noble <jer.no...@apple.com>
+
+ REGRESSION(r162679): Poster image visible under the video
+ https://bugs.webkit.org/show_bug.cgi?id=130783
+
+ Reviewed by Simon Fraser.
+
+ In the listed revision, we started checking for isRenderImage()
+ instead of isImage(). RenderMedias return 'true' for the first
+ but 'false' for the second. Change the if() statement to check
+ for isRenderMedia() in addition to !isRenderImage().
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
+
2014-03-26 Antti Koivisto <an...@apple.com>
Render tree construction is O(N^2) in number of siblings
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (166303 => 166304)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2014-03-26 18:35:55 UTC (rev 166303)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2014-03-26 18:37:44 UTC (rev 166304)
@@ -1838,7 +1838,7 @@
// that require painting. Direct compositing saves backing store.
bool RenderLayerBacking::isDirectlyCompositedImage() const
{
- if (!renderer().isRenderImage() || m_owningLayer.hasBoxDecorationsOrBackground() || renderer().hasClip())
+ if (!renderer().isRenderImage() || renderer().isMedia() || m_owningLayer.hasBoxDecorationsOrBackground() || renderer().hasClip())
return false;
RenderImage& imageRenderer = toRenderImage(renderer());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
