Title: [166574] trunk/Source/WebKit2
- Revision
- 166574
- Author
- zandober...@gmail.com
- Date
- 2014-04-01 02:07:25 -0700 (Tue, 01 Apr 2014)
Log Message
[GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy
https://bugs.webkit.org/show_bug.cgi?id=131015
Reviewed by Carlos Garcia Campos.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewDecidePolicy): Avoid copying the ResourceResponce object returned by webkitURIResponseGetResourceResponse.
That function already returns a reference, so the return value should be stored accordingly.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166573 => 166574)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 09:04:45 UTC (rev 166573)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 09:07:25 UTC (rev 166574)
@@ -1,3 +1,14 @@
+2014-04-01 Zan Dobersek <zdober...@igalia.com>
+
+ [GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy
+ https://bugs.webkit.org/show_bug.cgi?id=131015
+
+ Reviewed by Carlos Garcia Campos.
+
+ * UIProcess/API/gtk/WebKitWebView.cpp:
+ (webkitWebViewDecidePolicy): Avoid copying the ResourceResponce object returned by webkitURIResponseGetResourceResponse.
+ That function already returns a reference, so the return value should be stored accordingly.
+
2014-04-01 Eunmi Lee <eunmi15....@samsung.com>
[CoordinatedGraphics] Content scale factor should not be applied to draw contents when fixed layout is not used.
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (166573 => 166574)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-04-01 09:04:45 UTC (rev 166573)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-04-01 09:07:25 UTC (rev 166574)
@@ -273,7 +273,7 @@
}
WebKitURIResponse* response = webkit_response_policy_decision_get_response(WEBKIT_RESPONSE_POLICY_DECISION(decision));
- const ResourceResponse resourceResponse = webkitURIResponseGetResourceResponse(response);
+ const ResourceResponse& resourceResponse = webkitURIResponseGetResourceResponse(response);
if (resourceResponse.isAttachment()) {
webkit_policy_decision_download(decision);
return TRUE;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
