Log Message
Merge r166568 - [GTK] Readonly attributes installed as readwrite in GObject DOM bindings https://bugs.webkit.org/show_bug.cgi?id=130978
Reviewed by Carlos Garcia Campos. Unify how we decide if an attribute is readable or writeable and improve the code. This results in some attributes now being marked as read-only which didn't have corresponding case statements in the set_property switch statements and also correctly installs set_property support for some more POD types. * bindings/scripts/CodeGeneratorGObject.pm: (IsPropertyReadable): Added this helper to simplify deciding if an attribute is readable. (IsPropertyWriteable): Added this helper to simplify deciding if an attribute is writeable. Also update the list of types to reflect the full list of types we can generate setters for. (GenerateProperty): Use the IsPropertyWriteable helper instead of checking whether the attribute is read-only. Also fix generation of the blurb by using $mutableString instead of $mutableStringconst which isn't used. (GenerateProperties): Use grep and the new helpers to simplify the code. (GetReadableProperties): Deleted. (GetWriteableProperties): Deleted. * bindings/scripts/test/GObject: Update results
Modified Paths
- releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog
- releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
- releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp
- releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp
- releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp
- releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog (166578 => 166579)
--- releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-04-01 13:14:15 UTC (rev 166578)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-04-01 13:25:54 UTC (rev 166579)
@@ -1,3 +1,26 @@
+2014-04-01 Martin Robinson <mrobin...@igalia.com>
+
+ [GTK] Readonly attributes installed as readwrite in GObject DOM bindings
+ https://bugs.webkit.org/show_bug.cgi?id=130978
+
+ Reviewed by Carlos Garcia Campos.
+
+ Unify how we decide if an attribute is readable or writeable and improve the code.
+ This results in some attributes now being marked as read-only which didn't have
+ corresponding case statements in the set_property switch statements and also correctly
+ installs set_property support for some more POD types.
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (IsPropertyReadable): Added this helper to simplify deciding if an attribute is readable.
+ (IsPropertyWriteable): Added this helper to simplify deciding if an attribute is writeable. Also
+ update the list of types to reflect the full list of types we can generate setters for.
+ (GenerateProperty): Use the IsPropertyWriteable helper instead of checking whether the attribute is read-only.
+ Also fix generation of the blurb by using $mutableString instead of $mutableStringconst which isn't used.
+ (GenerateProperties): Use grep and the new helpers to simplify the code.
+ (GetReadableProperties): Deleted.
+ (GetWriteableProperties): Deleted.
+ * bindings/scripts/test/GObject: Update results
+
2014-03-30 Xabier Rodriguez Calvar <calva...@igalia.com>
[GTK] [TextureMapper] Weird brightness with some videos with acceletared compositing
Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (166578 => 166579)
--- releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-04-01 13:14:15 UTC (rev 166578)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-04-01 13:25:54 UTC (rev 166579)
@@ -412,41 +412,45 @@
return 1;
}
-sub GetReadableProperties {
- my $properties = shift;
+sub IsPropertyReadable {
+ my $property = shift;
+ return !SkipAttribute($property);
+}
- my @result = ();
+sub IsPropertyWriteable {
+ my $property = shift;
- foreach my $property (@{$properties}) {
- if (!SkipAttribute($property)) {
- push(@result, $property);
- }
+ if (!IsPropertyReadable($property)) {
+ return 0;
}
- return @result;
-}
+ if ($property->isReadOnly) {
+ return 0;
+ }
-sub GetWriteableProperties {
- my $properties = shift;
- my @result = ();
+ my $gtype = GetGValueTypeName($property->signature->type);
+ my $hasGtypeSignature = $gtype eq "boolean" || $gtype eq "float" || $gtype eq "double" ||
+ $gtype eq "int64" || $gtype eq "uint64" ||
+ $gtype eq "long" || $gtype eq "ulong" ||
+ $gtype eq "int" || $gtype eq "uint" ||
+ $gtype eq "short" || $gtype eq "ushort" ||
+ $gtype eq "int8" || $gtype eq "uint8" ||
+ $gtype eq "char" || $gtype eq "uchar" ||
+ $gtype eq "string";
+ if (!$hasGtypeSignature) {
+ return 0;
+ }
- foreach my $property (@{$properties}) {
- my $gtype = GetGValueTypeName($property->signature->type);
- my $hasGtypeSignature = ($gtype eq "boolean" || $gtype eq "float" || $gtype eq "double" ||
- $gtype eq "uint64" || $gtype eq "ulong" || $gtype eq "long" ||
- $gtype eq "uint" || $gtype eq "ushort" || $gtype eq "int8" ||
- $gtype eq "uint8" || $gtype eq "uchar" || $gtype eq "char" ||
- $gtype eq "string");
- # FIXME: We are not generating setters for 'Replaceable'
- # attributes now, but we should somehow.
- my $replaceable = $property->signature->extendedAttributes->{"Replaceable"};
- my $custom = $property->signature->extendedAttributes->{"CustomSetter"};
- if (!$property->isReadOnly && $hasGtypeSignature && !$replaceable && !$custom) {
- push(@result, $property);
- }
+ # FIXME: We are not generating setters for 'Replaceable' attributes now, but we should somehow.
+ if ($property->signature->extendedAttributes->{"Replaceable"}) {
+ return 0;
}
- return @result;
+ if ($property->signature->extendedAttributes->{"CustomSetter"}) {
+ return 0;
+ }
+
+ return 1;
}
sub GenerateConditionalWarning
@@ -508,15 +512,15 @@
my $gtype = GetGValueTypeName($propType);
my $gparamflag = "WEBKIT_PARAM_READABLE";
- my $writeable = !$attribute->isReadOnly;
+ my $writeable = IsPropertyWriteable($attribute);
my $mutableString = "read-only";
my $hasCustomSetter = $attribute->signature->extendedAttributes->{"CustomSetter"};
if ($writeable && $hasCustomSetter) {
- $mutableStringconst = "read-only (due to custom functions needed in webkitdom)";
+ $mutableString = "read-only (due to custom functions needed in webkitdom)";
} elsif ($writeable) {
$gparamflag = "WEBKIT_PARAM_READWRITE";
- $mutableStringconst = "read-write";
+ $mutableString = "read-write";
}
my $convertFunction = "";
@@ -637,8 +641,8 @@
# Properties
my $implContent = "";
- my @readableProperties = GetReadableProperties($interface->attributes);
- my @writeableProperties = GetWriteableProperties(\@readableProperties);
+ my @readableProperties = grep { IsPropertyReadable($_) } @{$interface->attributes};
+ my @writeableProperties = grep { IsPropertyWriteable($_) } @{$interface->attributes};
my $numProperties = scalar @readableProperties;
# Properties
Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp (166578 => 166579)
--- releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp 2014-04-01 13:14:15 UTC (rev 166578)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp 2014-04-01 13:25:54 UTC (rev 166579)
@@ -273,7 +273,7 @@
g_param_spec_string(
"implements-str2",
"TestInterface:implements-str2",
- "read-only gchar* TestInterface:implements-str2",
+ "read-write gchar* TestInterface:implements-str2",
"",
WEBKIT_PARAM_READWRITE));
@@ -285,7 +285,7 @@
"TestInterface:implements-node",
"read-only WebKitDOMNode* TestInterface:implements-node",
WEBKIT_TYPE_DOM_NODE,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -303,7 +303,7 @@
g_param_spec_string(
"supplemental-str2",
"TestInterface:supplemental-str2",
- "read-only gchar* TestInterface:supplemental-str2",
+ "read-write gchar* TestInterface:supplemental-str2",
"",
WEBKIT_PARAM_READWRITE));
@@ -315,7 +315,7 @@
"TestInterface:supplemental-node",
"read-only WebKitDOMNode* TestInterface:supplemental-node",
WEBKIT_TYPE_DOM_NODE,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
}
Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp (166578 => 166579)
--- releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp 2014-04-01 13:14:15 UTC (rev 166578)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp 2014-04-01 13:25:54 UTC (rev 166579)
@@ -160,6 +160,10 @@
coreSelf->setOctetAttr((g_value_get_uint8(value)));
break;
}
+ case PROP_SHORT_ATTR: {
+ coreSelf->setShortAttr((g_value_get_int(value)));
+ break;
+ }
case PROP_UNSIGNED_SHORT_ATTR: {
coreSelf->setUnsignedShortAttr((g_value_get_uint(value)));
break;
@@ -168,6 +172,10 @@
coreSelf->setLongAttr((g_value_get_long(value)));
break;
}
+ case PROP_LONG_LONG_ATTR: {
+ coreSelf->setLongLongAttr((g_value_get_int64(value)));
+ break;
+ }
case PROP_UNSIGNED_LONG_LONG_ATTR: {
coreSelf->setUnsignedLongLongAttr((g_value_get_uint64(value)));
break;
@@ -628,7 +636,7 @@
g_param_spec_int8(
"byte-attr",
"TestObj:byte-attr",
- "read-only gint8 TestObj:byte-attr",
+ "read-write gint8 TestObj:byte-attr",
G_MININT8, G_MAXINT8, 0,
WEBKIT_PARAM_READWRITE));
@@ -638,7 +646,7 @@
g_param_spec_uint8(
"octet-attr",
"TestObj:octet-attr",
- "read-only guint8 TestObj:octet-attr",
+ "read-write guint8 TestObj:octet-attr",
0, G_MAXUINT8, 0,
WEBKIT_PARAM_READWRITE));
@@ -648,7 +656,7 @@
g_param_spec_int(
"short-attr",
"TestObj:short-attr",
- "read-only gshort TestObj:short-attr",
+ "read-write gshort TestObj:short-attr",
G_MININT, G_MAXINT, 0,
WEBKIT_PARAM_READWRITE));
@@ -658,7 +666,7 @@
g_param_spec_uint(
"unsigned-short-attr",
"TestObj:unsigned-short-attr",
- "read-only gushort TestObj:unsigned-short-attr",
+ "read-write gushort TestObj:unsigned-short-attr",
0, G_MAXUINT, 0,
WEBKIT_PARAM_READWRITE));
@@ -668,7 +676,7 @@
g_param_spec_long(
"long-attr",
"TestObj:long-attr",
- "read-only glong TestObj:long-attr",
+ "read-write glong TestObj:long-attr",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -678,7 +686,7 @@
g_param_spec_int64(
"long-long-attr",
"TestObj:long-long-attr",
- "read-only gint64 TestObj:long-long-attr",
+ "read-write gint64 TestObj:long-long-attr",
G_MININT64, G_MAXINT64, 0,
WEBKIT_PARAM_READWRITE));
@@ -688,7 +696,7 @@
g_param_spec_uint64(
"unsigned-long-long-attr",
"TestObj:unsigned-long-long-attr",
- "read-only guint64 TestObj:unsigned-long-long-attr",
+ "read-write guint64 TestObj:unsigned-long-long-attr",
0, G_MAXUINT64, 0,
WEBKIT_PARAM_READWRITE));
@@ -698,7 +706,7 @@
g_param_spec_string(
"string-attr",
"TestObj:string-attr",
- "read-only gchar* TestObj:string-attr",
+ "read-write gchar* TestObj:string-attr",
"",
WEBKIT_PARAM_READWRITE));
@@ -710,7 +718,7 @@
"TestObj:test-obj-attr",
"read-only WebKitDOMTestObj* TestObj:test-obj-attr",
WEBKIT_TYPE_DOM_TEST_OBJ,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -720,7 +728,7 @@
"TestObj:xml-obj-attr",
"read-only WebKitDOMTestObj* TestObj:xml-obj-attr",
WEBKIT_TYPE_DOM_TEST_OBJ,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -728,7 +736,7 @@
g_param_spec_boolean(
"create",
"TestObj:create",
- "read-only gboolean TestObj:create",
+ "read-write gboolean TestObj:create",
FALSE,
WEBKIT_PARAM_READWRITE));
@@ -738,7 +746,7 @@
g_param_spec_string(
"reflected-string-attr",
"TestObj:reflected-string-attr",
- "read-only gchar* TestObj:reflected-string-attr",
+ "read-write gchar* TestObj:reflected-string-attr",
"",
WEBKIT_PARAM_READWRITE));
@@ -748,7 +756,7 @@
g_param_spec_long(
"reflected-integral-attr",
"TestObj:reflected-integral-attr",
- "read-only glong TestObj:reflected-integral-attr",
+ "read-write glong TestObj:reflected-integral-attr",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -758,7 +766,7 @@
g_param_spec_ulong(
"reflected-unsigned-integral-attr",
"TestObj:reflected-unsigned-integral-attr",
- "read-only gulong TestObj:reflected-unsigned-integral-attr",
+ "read-write gulong TestObj:reflected-unsigned-integral-attr",
0, G_MAXULONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -768,7 +776,7 @@
g_param_spec_boolean(
"reflected-boolean-attr",
"TestObj:reflected-boolean-attr",
- "read-only gboolean TestObj:reflected-boolean-attr",
+ "read-write gboolean TestObj:reflected-boolean-attr",
FALSE,
WEBKIT_PARAM_READWRITE));
@@ -778,7 +786,7 @@
g_param_spec_string(
"reflected-url-attr",
"TestObj:reflected-url-attr",
- "read-only gchar* TestObj:reflected-url-attr",
+ "read-write gchar* TestObj:reflected-url-attr",
"",
WEBKIT_PARAM_READWRITE));
@@ -788,7 +796,7 @@
g_param_spec_string(
"reflected-string-attr",
"TestObj:reflected-string-attr",
- "read-only gchar* TestObj:reflected-string-attr",
+ "read-write gchar* TestObj:reflected-string-attr",
"",
WEBKIT_PARAM_READWRITE));
@@ -798,7 +806,7 @@
g_param_spec_long(
"reflected-custom-integral-attr",
"TestObj:reflected-custom-integral-attr",
- "read-only glong TestObj:reflected-custom-integral-attr",
+ "read-write glong TestObj:reflected-custom-integral-attr",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -808,7 +816,7 @@
g_param_spec_boolean(
"reflected-custom-boolean-attr",
"TestObj:reflected-custom-boolean-attr",
- "read-only gboolean TestObj:reflected-custom-boolean-attr",
+ "read-write gboolean TestObj:reflected-custom-boolean-attr",
FALSE,
WEBKIT_PARAM_READWRITE));
@@ -818,7 +826,7 @@
g_param_spec_string(
"reflected-custom-url-attr",
"TestObj:reflected-custom-url-attr",
- "read-only gchar* TestObj:reflected-custom-url-attr",
+ "read-write gchar* TestObj:reflected-custom-url-attr",
"",
WEBKIT_PARAM_READWRITE));
@@ -828,7 +836,7 @@
g_param_spec_long(
"attr-with-getter-exception",
"TestObj:attr-with-getter-exception",
- "read-only glong TestObj:attr-with-getter-exception",
+ "read-write glong TestObj:attr-with-getter-exception",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -838,7 +846,7 @@
g_param_spec_long(
"attr-with-setter-exception",
"TestObj:attr-with-setter-exception",
- "read-only glong TestObj:attr-with-setter-exception",
+ "read-write glong TestObj:attr-with-setter-exception",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -848,7 +856,7 @@
g_param_spec_string(
"string-attr-with-getter-exception",
"TestObj:string-attr-with-getter-exception",
- "read-only gchar* TestObj:string-attr-with-getter-exception",
+ "read-write gchar* TestObj:string-attr-with-getter-exception",
"",
WEBKIT_PARAM_READWRITE));
@@ -858,7 +866,7 @@
g_param_spec_string(
"string-attr-with-setter-exception",
"TestObj:string-attr-with-setter-exception",
- "read-only gchar* TestObj:string-attr-with-setter-exception",
+ "read-write gchar* TestObj:string-attr-with-setter-exception",
"",
WEBKIT_PARAM_READWRITE));
@@ -868,7 +876,7 @@
g_param_spec_long(
"with-script-state-attribute",
"TestObj:with-script-state-attribute",
- "read-only glong TestObj:with-script-state-attribute",
+ "read-write glong TestObj:with-script-state-attribute",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -880,7 +888,7 @@
"TestObj:with-script-execution-context-attribute",
"read-only WebKitDOMTestObj* TestObj:with-script-execution-context-attribute",
WEBKIT_TYPE_DOM_TEST_OBJ,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -890,7 +898,7 @@
"TestObj:with-script-state-attribute-raises",
"read-only WebKitDOMTestObj* TestObj:with-script-state-attribute-raises",
WEBKIT_TYPE_DOM_TEST_OBJ,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -900,7 +908,7 @@
"TestObj:with-script-execution-context-attribute-raises",
"read-only WebKitDOMTestObj* TestObj:with-script-execution-context-attribute-raises",
WEBKIT_TYPE_DOM_TEST_OBJ,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -910,7 +918,7 @@
"TestObj:with-script-execution-context-and-script-state-attribute",
"read-only WebKitDOMTestObj* TestObj:with-script-execution-context-and-script-state-attribute",
WEBKIT_TYPE_DOM_TEST_OBJ,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -920,7 +928,7 @@
"TestObj:with-script-execution-context-and-script-state-attribute-raises",
"read-only WebKitDOMTestObj* TestObj:with-script-execution-context-and-script-state-attribute-raises",
WEBKIT_TYPE_DOM_TEST_OBJ,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -930,7 +938,7 @@
"TestObj:with-script-execution-context-and-script-state-with-spaces-attribute",
"read-only WebKitDOMTestObj* TestObj:with-script-execution-context-and-script-state-with-spaces-attribute",
WEBKIT_TYPE_DOM_TEST_OBJ,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -940,7 +948,7 @@
"TestObj:with-script-arguments-and-call-stack-attribute",
"read-only WebKitDOMTestObj* TestObj:with-script-arguments-and-call-stack-attribute",
WEBKIT_TYPE_DOM_TEST_OBJ,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -948,7 +956,7 @@
g_param_spec_long(
"conditional-attr1",
"TestObj:conditional-attr1",
- "read-only glong TestObj:conditional-attr1",
+ "read-write glong TestObj:conditional-attr1",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -958,7 +966,7 @@
g_param_spec_long(
"conditional-attr2",
"TestObj:conditional-attr2",
- "read-only glong TestObj:conditional-attr2",
+ "read-write glong TestObj:conditional-attr2",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -968,7 +976,7 @@
g_param_spec_long(
"conditional-attr3",
"TestObj:conditional-attr3",
- "read-only glong TestObj:conditional-attr3",
+ "read-write glong TestObj:conditional-attr3",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -980,7 +988,7 @@
"TestObj:any-attribute",
"read-only WebKitDOMany* TestObj:any-attribute",
WEBKIT_TYPE_DOM_ANY,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -1000,7 +1008,7 @@
"TestObj:mutable-point",
"read-only WebKitDOMSVGPoint* TestObj:mutable-point",
WEBKIT_TYPE_DOM_SVG_POINT,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -1010,7 +1018,7 @@
"TestObj:immutable-point",
"read-only WebKitDOMSVGPoint* TestObj:immutable-point",
WEBKIT_TYPE_DOM_SVG_POINT,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -1018,7 +1026,7 @@
g_param_spec_long(
"strawberry",
"TestObj:strawberry",
- "read-only glong TestObj:strawberry",
+ "read-write glong TestObj:strawberry",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -1028,7 +1036,7 @@
g_param_spec_float(
"strict-float",
"TestObj:strict-float",
- "read-only gfloat TestObj:strict-float",
+ "read-write gfloat TestObj:strict-float",
-G_MAXFLOAT, G_MAXFLOAT, 0,
WEBKIT_PARAM_READWRITE));
@@ -1048,7 +1056,7 @@
g_param_spec_long(
"id",
"TestObj:id",
- "read-only glong TestObj:id",
+ "read-write glong TestObj:id",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -1118,7 +1126,7 @@
g_param_spec_long(
"nullable-long-settable-attribute",
"TestObj:nullable-long-settable-attribute",
- "read-only glong TestObj:nullable-long-settable-attribute",
+ "read-write glong TestObj:nullable-long-settable-attribute",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -1128,7 +1136,7 @@
g_param_spec_long(
"nullable-string-value",
"TestObj:nullable-string-value",
- "read-only glong TestObj:nullable-string-value",
+ "read-write glong TestObj:nullable-string-value",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp (166578 => 166579)
--- releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp 2014-04-01 13:14:15 UTC (rev 166578)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp 2014-04-01 13:25:54 UTC (rev 166579)
@@ -172,7 +172,7 @@
"TestSerializedScriptValueInterface:value",
"read-only WebKitDOMSerializedScriptValue* TestSerializedScriptValueInterface:value",
WEBKIT_TYPE_DOM_SERIALIZED_SCRIPT_VALUE,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -192,7 +192,7 @@
"TestSerializedScriptValueInterface:cached-value",
"read-only WebKitDOMSerializedScriptValue* TestSerializedScriptValueInterface:cached-value",
WEBKIT_TYPE_DOM_SERIALIZED_SCRIPT_VALUE,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp (166578 => 166579)
--- releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp 2014-04-01 13:14:15 UTC (rev 166578)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp 2014-04-01 13:25:54 UTC (rev 166579)
@@ -193,7 +193,7 @@
g_param_spec_uint64(
"unsigned-long-long-attr",
"TestTypedefs:unsigned-long-long-attr",
- "read-only guint64 TestTypedefs:unsigned-long-long-attr",
+ "read-write guint64 TestTypedefs:unsigned-long-long-attr",
0, G_MAXUINT64, 0,
WEBKIT_PARAM_READWRITE));
@@ -205,7 +205,7 @@
"TestTypedefs:immutable-serialized-script-value",
"read-only WebKitDOMSerializedScriptValue* TestTypedefs:immutable-serialized-script-value",
WEBKIT_TYPE_DOM_SERIALIZED_SCRIPT_VALUE,
- WEBKIT_PARAM_READWRITE));
+ WEBKIT_PARAM_READABLE));
g_object_class_install_property(
gobjectClass,
@@ -213,7 +213,7 @@
g_param_spec_long(
"attr-with-getter-exception",
"TestTypedefs:attr-with-getter-exception",
- "read-only glong TestTypedefs:attr-with-getter-exception",
+ "read-write glong TestTypedefs:attr-with-getter-exception",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -223,7 +223,7 @@
g_param_spec_long(
"attr-with-setter-exception",
"TestTypedefs:attr-with-setter-exception",
- "read-only glong TestTypedefs:attr-with-setter-exception",
+ "read-write glong TestTypedefs:attr-with-setter-exception",
G_MINLONG, G_MAXLONG, 0,
WEBKIT_PARAM_READWRITE));
@@ -233,7 +233,7 @@
g_param_spec_string(
"string-attr-with-getter-exception",
"TestTypedefs:string-attr-with-getter-exception",
- "read-only gchar* TestTypedefs:string-attr-with-getter-exception",
+ "read-write gchar* TestTypedefs:string-attr-with-getter-exception",
"",
WEBKIT_PARAM_READWRITE));
@@ -243,7 +243,7 @@
g_param_spec_string(
"string-attr-with-setter-exception",
"TestTypedefs:string-attr-with-setter-exception",
- "read-only gchar* TestTypedefs:string-attr-with-setter-exception",
+ "read-write gchar* TestTypedefs:string-attr-with-setter-exception",
"",
WEBKIT_PARAM_READWRITE));
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
