Title: [166985] trunk/Source/WebKit2
- Revision
- 166985
- Author
- rn...@webkit.org
- Date
- 2014-04-08 17:37:57 -0700 (Tue, 08 Apr 2014)
Log Message
REGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing
https://bugs.webkit.org/show_bug.cgi?id=131409
Reviewed by Anders Carlsson.
Create an empty API::InjectedBundle::FormClient to avoid crashing inside
m_mainFrame->coreFrame()->loader().detachFromParent().
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166984 => 166985)
--- trunk/Source/WebKit2/ChangeLog 2014-04-09 00:22:46 UTC (rev 166984)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-09 00:37:57 UTC (rev 166985)
@@ -1,3 +1,16 @@
+2014-04-08 Ryosuke Niwa <rn...@webkit.org>
+
+ REGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing
+ https://bugs.webkit.org/show_bug.cgi?id=131409
+
+ Reviewed by Anders Carlsson.
+
+ Create an empty API::InjectedBundle::FormClient to avoid crashing inside
+ m_mainFrame->coreFrame()->loader().detachFromParent().
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::close):
+
2014-04-08 Tim Horton <timothy_hor...@apple.com>
Unify and factor out page overlay implementations
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (166984 => 166985)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-04-09 00:22:46 UTC (rev 166984)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-04-09 00:37:57 UTC (rev 166985)
@@ -886,7 +886,7 @@
m_contextMenuClient.initialize(0);
#endif
m_editorClient.initialize(0);
- m_formClient = std::unique_ptr<API::InjectedBundle::FormClient>();
+ m_formClient = std::make_ptr<API::InjectedBundle::FormClient>();
m_loaderClient.initialize(0);
m_policyClient.initialize(0);
m_resourceLoadClient.initialize(0);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
