Title: [167728] trunk/Tools
- Revision
- 167728
- Author
- timothy_hor...@apple.com
- Date
- 2014-04-23 15:22:00 -0700 (Wed, 23 Apr 2014)
Log Message
Mock scrollbars don't always work in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=132082
Reviewed by Alexey Proskuryakov.
* DumpRenderTree/mac/DumpRenderTree.mm:
(prepareConsistentTestingEnvironment):
Set the mock scrollbar setting before creating the WebView, as this setting
cannot be dynamically changed, so any scrollbars that are created during
WebView initialization and are not replaced before snapshotting will end
up being platform scrollbars instead of mock ones.
WebKitTestRunner already sets this preference before creating WKViews,
so we're just matching its behavior.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (167727 => 167728)
--- trunk/Tools/ChangeLog 2014-04-23 22:19:19 UTC (rev 167727)
+++ trunk/Tools/ChangeLog 2014-04-23 22:22:00 UTC (rev 167728)
@@ -1,3 +1,19 @@
+2014-04-23 Tim Horton <timothy_hor...@apple.com>
+
+ Mock scrollbars don't always work in DumpRenderTree
+ https://bugs.webkit.org/show_bug.cgi?id=132082
+
+ Reviewed by Alexey Proskuryakov.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (prepareConsistentTestingEnvironment):
+ Set the mock scrollbar setting before creating the WebView, as this setting
+ cannot be dynamically changed, so any scrollbars that are created during
+ WebView initialization and are not replaced before snapshotting will end
+ up being platform scrollbars instead of mock ones.
+ WebKitTestRunner already sets this preference before creating WKViews,
+ so we're just matching its behavior.
+
2014-04-23 Carlos Garcia Campos <cgar...@igalia.com>
[GTK] ShadowRoot API was removed in r164131
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (167727 => 167728)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2014-04-23 22:19:19 UTC (rev 167727)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2014-04-23 22:22:00 UTC (rev 167728)
@@ -1098,6 +1098,9 @@
adjustFonts();
registerMockScrollbars();
+
+ // The mock scrollbars setting cannot be modified after creating a view, so we have to do it now.
+ [[WebPreferences standardPreferences] setMockScrollbarsEnabled:YES];
#else
activateFontsIOS();
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
