Title: [167961] trunk/Source/WebKit2
- Revision
- 167961
- Author
- roger_f...@apple.com
- Date
- 2014-04-29 15:14:37 -0700 (Tue, 29 Apr 2014)
Log Message
Don't immediately snapshot plugin to allow for proper dominant plugin detection.
https://bugs.webkit.org/show_bug.cgi?id=132294.
<rdar://problem/16745679>
Reviewed by Dean Jackson.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin):
Instead of immediately setting the display state to DisplaySnapshot,
put it on a timer to let the page fully layout and get hit test properly.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (167960 => 167961)
--- trunk/Source/WebKit2/ChangeLog 2014-04-29 22:10:32 UTC (rev 167960)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-29 22:14:37 UTC (rev 167961)
@@ -1,3 +1,16 @@
+2014-04-29 Roger Fong <roger_f...@apple.com>
+
+ Don't immediately snapshot plugin to allow for proper dominant plugin detection.
+ https://bugs.webkit.org/show_bug.cgi?id=132294.
+ <rdar://problem/16745679>
+
+ Reviewed by Dean Jackson.
+
+ * WebProcess/Plugins/PluginView.cpp:
+ (WebKit::PluginView::didInitializePlugin):
+ Instead of immediately setting the display state to DisplaySnapshot,
+ put it on a timer to let the page fully layout and get hit test properly.
+
2014-04-28 Roger Fong <roger_f...@apple.com>
Plugins hidden by images should autoplay.
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (167960 => 167961)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2014-04-29 22:10:32 UTC (rev 167960)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2014-04-29 22:14:37 UTC (rev 167961)
@@ -622,7 +622,7 @@
m_pluginElement->setNeedsStyleRecalc(SyntheticStyleChange);
}
if (frame() && !frame()->settings().maximumPlugInSnapshotAttempts()) {
- m_pluginElement->setDisplayState(HTMLPlugInElement::DisplayingSnapshot);
+ beginSnapshottingRunningPlugin();
return;
}
m_pluginSnapshotTimer.restart();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
