Title: [168088] trunk
- Revision
- 168088
- Author
- hy...@apple.com
- Date
- 2014-04-30 23:44:54 -0700 (Wed, 30 Apr 2014)
Log Message
REGRESSION (r168046): [New Multicolumn] LeftToRight-rl.html (and all the other reversed/block-axis pagination tests) fail
https://bugs.webkit.org/show_bug.cgi?id=132419
Reviewed by Andreas Kling.
Source/WebCore:
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::initialBlockOffsetForPainting):
Don't flip here. The old code needed to do that, but the new code doesn't.
LayoutTests:
* platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png:
* platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (168087 => 168088)
--- trunk/LayoutTests/ChangeLog 2014-05-01 06:38:12 UTC (rev 168087)
+++ trunk/LayoutTests/ChangeLog 2014-05-01 06:44:54 UTC (rev 168088)
@@ -1,3 +1,13 @@
+2014-04-30 David Hyatt <hy...@apple.com>
+
+ REGRESSION (r168046): [New Multicolumn] LeftToRight-rl.html (and all the other reversed/block-axis pagination tests) fail
+ https://bugs.webkit.org/show_bug.cgi?id=132419
+
+ Reviewed by Andreas Kling.
+
+ * platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png:
+ * platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png:
+
2014-04-30 Simon Fraser <simon.fra...@apple.com>
[iOS WK2] Some accerated overflow-scroll doesn't scroll correctly
Modified: trunk/LayoutTests/platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png
(Binary files differ)
Modified: trunk/Source/WebCore/ChangeLog (168087 => 168088)
--- trunk/Source/WebCore/ChangeLog 2014-05-01 06:38:12 UTC (rev 168087)
+++ trunk/Source/WebCore/ChangeLog 2014-05-01 06:44:54 UTC (rev 168088)
@@ -1,3 +1,14 @@
+2014-04-30 David Hyatt <hy...@apple.com>
+
+ REGRESSION (r168046): [New Multicolumn] LeftToRight-rl.html (and all the other reversed/block-axis pagination tests) fail
+ https://bugs.webkit.org/show_bug.cgi?id=132419
+
+ Reviewed by Andreas Kling.
+
+ * rendering/RenderMultiColumnSet.cpp:
+ (WebCore::RenderMultiColumnSet::initialBlockOffsetForPainting):
+ Don't flip here. The old code needed to do that, but the new code doesn't.
+
2014-04-30 Alexey Proskuryakov <a...@apple.com>
Roll out fix for https://bugs.webkit.org/show_bug.cgi?id=131637:
Modified: trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp (168087 => 168088)
--- trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp 2014-05-01 06:38:12 UTC (rev 168087)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp 2014-05-01 06:44:54 UTC (rev 168088)
@@ -674,8 +674,6 @@
if (!progressionIsInline && progressionReversed) {
LayoutRect colRect = columnRectAt(0);
result = isHorizontalWritingMode() ? colRect.y() : colRect.x();
- if (style().isFlippedBlocksWritingMode())
- result = -result;
}
return result;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
