Diff
Modified: trunk/Source/WebKit2/ChangeLog (168122 => 168123)
--- trunk/Source/WebKit2/ChangeLog 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/ChangeLog 2014-05-01 22:03:54 UTC (rev 168123)
@@ -1,5 +1,26 @@
2014-05-01 Anders Carlsson <ander...@apple.com>
+ Remove WKBundleSetShouldTrackVisitedLinks and associate code
+ https://bugs.webkit.org/show_bug.cgi?id=132441
+
+ Reviewed by Sam Weinig.
+
+ * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
+ (WKBundleSetShouldTrackVisitedLinks): Deleted.
+ * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::setShouldTrackVisitedLinks): Deleted.
+ * WebProcess/InjectedBundle/InjectedBundle.h:
+ * WebProcess/WebPage/VisitedLinkTableController.cpp:
+ (WebKit::VisitedLinkTableController::addVisitedLink):
+ * WebProcess/WebProcess.cpp:
+ (WebKit::WebProcess::WebProcess):
+ (WebKit::WebProcess::setShouldTrackVisitedLinks): Deleted.
+ * WebProcess/WebProcess.h:
+ (WebKit::WebProcess::shouldTrackVisitedLinks): Deleted.
+
+2014-05-01 Anders Carlsson <ander...@apple.com>
+
window.testRunner.keepWebHistory() should update the UI process state
https://bugs.webkit.org/show_bug.cgi?id=132440
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp (168122 => 168123)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2014-05-01 22:03:54 UTC (rev 168123)
@@ -63,11 +63,6 @@
return toAPI(toImpl(bundleRef)->webConnectionToUIProcess());
}
-void WKBundleSetShouldTrackVisitedLinks(WKBundleRef bundleRef, bool shouldTrackVisitedLinks)
-{
- toImpl(bundleRef)->setShouldTrackVisitedLinks(shouldTrackVisitedLinks);
-}
-
void WKBundleRemoveAllVisitedLinks(WKBundleRef bundleRef)
{
toImpl(bundleRef)->removeAllVisitedLinks();
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h (168122 => 168123)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h 2014-05-01 22:03:54 UTC (rev 168123)
@@ -41,7 +41,6 @@
#endif
// TestRunner only SPI
-WK_EXPORT void WKBundleSetShouldTrackVisitedLinks(WKBundleRef bundle, bool shouldTrackVisitedLinks);
WK_EXPORT void WKBundleSetAlwaysAcceptCookies(WKBundleRef bundle, bool);
WK_EXPORT void WKBundleRemoveAllVisitedLinks(WKBundleRef bundle);
WK_EXPORT void WKBundleActivateMacFontAscentHack(WKBundleRef bundle);
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (168122 => 168123)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2014-05-01 22:03:54 UTC (rev 168123)
@@ -130,11 +130,6 @@
return WebProcess::shared().webConnectionToUIProcess();
}
-void InjectedBundle::setShouldTrackVisitedLinks(bool shouldTrackVisitedLinks)
-{
- WebProcess::shared().setShouldTrackVisitedLinks(shouldTrackVisitedLinks);
-}
-
void InjectedBundle::setAlwaysAcceptCookies(bool accept)
{
WebProcess::shared().supplement<WebCookieManager>()->setHTTPCookieAcceptPolicy(accept ? HTTPCookieAcceptPolicyAlways : HTTPCookieAcceptPolicyOnlyFromMainDocumentDomain);
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h (168122 => 168123)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2014-05-01 22:03:54 UTC (rev 168123)
@@ -100,7 +100,6 @@
WebConnection* webConnectionToUIProcess() const;
// TestRunner only SPI
- void setShouldTrackVisitedLinks(bool);
void setAlwaysAcceptCookies(bool);
void removeAllVisitedLinks();
void setCacheModel(uint32_t);
Modified: trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp (168122 => 168123)
--- trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp 2014-05-01 22:03:54 UTC (rev 168123)
@@ -81,9 +81,6 @@
if (m_visitedLinkTable.isLinkVisited(linkHash))
return;
- if (!WebProcess::shared().shouldTrackVisitedLinks())
- return;
-
WebPage* webPage = WebPage::fromCorePage(&page);
if (!webPage)
return;
Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (168122 => 168123)
--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2014-05-01 22:03:54 UTC (rev 168123)
@@ -150,7 +150,6 @@
, m_viewUpdateDispatcher(ViewUpdateDispatcher::create())
#endif // PLATFORM(IOS)
, m_inDidClose(false)
- , m_shouldTrackVisitedLinks(true)
, m_hasSetCacheModel(false)
, m_cacheModel(CacheModelDocumentViewer)
#if PLATFORM(COCOA)
@@ -396,12 +395,6 @@
}
#endif // ENABLE(NETWORK_PROCESS)
-void WebProcess::setShouldTrackVisitedLinks(bool shouldTrackVisitedLinks)
-{
- m_shouldTrackVisitedLinks = shouldTrackVisitedLinks;
- PageGroup::setShouldTrackVisitedLinks(shouldTrackVisitedLinks);
-}
-
void WebProcess::registerURLSchemeAsEmptyDocument(const String& urlScheme)
{
SchemeRegistry::registerURLSchemeAsEmptyDocument(urlScheme);
Modified: trunk/Source/WebKit2/WebProcess/WebProcess.h (168122 => 168123)
--- trunk/Source/WebKit2/WebProcess/WebProcess.h 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.h 2014-05-01 22:03:54 UTC (rev 168123)
@@ -115,11 +115,6 @@
mach_port_t compositingRenderServerPort() const { return m_compositingRenderServerPort; }
#endif
- // FIXME: This is only used by the injected bundle for layout tests.
- // WebKitTestRunner should just post a message to change whether visited links should be added.
- bool shouldTrackVisitedLinks() const { return m_shouldTrackVisitedLinks; }
- void setShouldTrackVisitedLinks(bool);
-
bool shouldPlugInAutoStartFromOrigin(const WebPage*, const String& pageOrigin, const String& pluginOrigin, const String& mimeType);
void plugInDidStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType);
void plugInDidReceiveUserInteraction(const String& pageOrigin, const String& pluginOrigin, const String& mimeType);
@@ -293,9 +288,6 @@
bool m_inDidClose;
- // FIXME: Whether visited links should be tracked or not should be handled in the UI process.
- bool m_shouldTrackVisitedLinks;
-
HashMap<unsigned, double> m_plugInAutoStartOriginHashes;
HashSet<String> m_plugInAutoStartOrigins;
