Title: [168197] trunk/Source/_javascript_Core
Revision
168197
Author
msab...@apple.com
Date
2014-05-02 15:24:37 -0700 (Fri, 02 May 2014)

Log Message

"arm64 function not 4-byte aligned" warnings when building JSC
https://bugs.webkit.org/show_bug.cgi?id=132495

Reviewed by Geoffrey Garen.

Added ".align 4" for both ARM Thumb2 and ARM 64 to silence the linker.

* llint/LowLevelInterpreter.cpp:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (168196 => 168197)


--- trunk/Source/_javascript_Core/ChangeLog	2014-05-02 22:05:26 UTC (rev 168196)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-05-02 22:24:37 UTC (rev 168197)
@@ -1,3 +1,14 @@
+2014-05-02  Michael Saboff  <msab...@apple.com>
+
+        "arm64 function not 4-byte aligned" warnings when building JSC
+        https://bugs.webkit.org/show_bug.cgi?id=132495
+
+        Reviewed by Geoffrey Garen.
+
+        Added ".align 4" for both ARM Thumb2 and ARM 64 to silence the linker.
+
+        * llint/LowLevelInterpreter.cpp:
+
 2014-05-02  Mark Hahnenberg  <mhahnenb...@apple.com>
 
         Fix cloop build after r168178

Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp (168196 => 168197)


--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp	2014-05-02 22:05:26 UTC (rev 168196)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp	2014-05-02 22:24:37 UTC (rev 168197)
@@ -503,11 +503,19 @@
 #if CPU(ARM_THUMB2)
 #define OFFLINE_ASM_GLOBAL_LABEL(label)          \
     ".text\n"                                    \
+    ".align 4\n"                                 \
     ".globl " SYMBOL_STRING(label) "\n"          \
     HIDE_SYMBOL(label) "\n"                      \
     ".thumb\n"                                   \
     ".thumb_func " THUMB_FUNC_PARAM(label) "\n"  \
     SYMBOL_STRING(label) ":\n"
+#elif CPU(ARM64)
+#define OFFLINE_ASM_GLOBAL_LABEL(label)         \
+    ".text\n"                                   \
+    ".align 4\n"                                \
+    ".globl " SYMBOL_STRING(label) "\n"         \
+    HIDE_SYMBOL(label) "\n"                     \
+    SYMBOL_STRING(label) ":\n"
 #else
 #define OFFLINE_ASM_GLOBAL_LABEL(label)         \
     ".text\n"                                   \
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to