Title: [168524] trunk
- Revision
- 168524
- Author
- commit-qu...@webkit.org
- Date
- 2014-05-09 03:58:14 -0700 (Fri, 09 May 2014)
Log Message
ASSERTION FAILED: !m_code || m_code == defaultExceptionCode
in WebCore::constructQualifiedName
https://bugs.webkit.org/show_bug.cgi?id=132343
'Remove bad assertion in SVGSMILElement's constructQualifiedName() by passing
IGNORE_EXCEPTION instead ASSERT_NO_EXCEPTION to Document::parseQualifiedName().
The constructQualifiedName() function handles parseQualifiedName() failures
propertly by returning early so there is no reason to assert on parsing
failures.'
Blink merge: http://src.chromium.org/viewvc/blink?view=revision&revision=173564
Based on the patch made by Christophe Dumez <ch.du...@samsung.com>.
Patch by Martin Hodovan <mhodo...@inf.u-szeged.hu> on 2014-05-09
Reviewed by Dirk Schulze.
Source/WebCore:
Test: svg/custom/bad-attributeName-crash.html
* svg/animation/SVGSMILElement.cpp:
(WebCore::constructQualifiedName):
LayoutTests:
* svg/custom/bad-attributeName-crash-expected.txt: Added.
* svg/custom/bad-attributeName-crash.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (168523 => 168524)
--- trunk/LayoutTests/ChangeLog 2014-05-09 07:10:41 UTC (rev 168523)
+++ trunk/LayoutTests/ChangeLog 2014-05-09 10:58:14 UTC (rev 168524)
@@ -1,3 +1,23 @@
+2014-05-09 Martin Hodovan <mhodo...@inf.u-szeged.hu>
+
+ ASSERTION FAILED: !m_code || m_code == defaultExceptionCode
+ in WebCore::constructQualifiedName
+ https://bugs.webkit.org/show_bug.cgi?id=132343
+
+ 'Remove bad assertion in SVGSMILElement's constructQualifiedName() by passing
+ IGNORE_EXCEPTION instead ASSERT_NO_EXCEPTION to Document::parseQualifiedName().
+ The constructQualifiedName() function handles parseQualifiedName() failures
+ propertly by returning early so there is no reason to assert on parsing
+ failures.'
+
+ Blink merge: http://src.chromium.org/viewvc/blink?view=revision&revision=173564
+ Based on the patch made by Christophe Dumez <ch.du...@samsung.com>.
+
+ Reviewed by Dirk Schulze.
+
+ * svg/custom/bad-attributeName-crash-expected.txt: Added.
+ * svg/custom/bad-attributeName-crash.html: Added.
+
2014-05-08 Alexey Proskuryakov <a...@apple.com>
REGRESSION (r168518): Multiple tests for workers in blobs assert
Added: trunk/LayoutTests/svg/custom/bad-attributeName-crash-expected.txt (0 => 168524)
--- trunk/LayoutTests/svg/custom/bad-attributeName-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/bad-attributeName-crash-expected.txt 2014-05-09 10:58:14 UTC (rev 168524)
@@ -0,0 +1,9 @@
+Tests that we do not crash on a bad attribute name.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/svg/custom/bad-attributeName-crash.html (0 => 168524)
--- trunk/LayoutTests/svg/custom/bad-attributeName-crash.html (rev 0)
+++ trunk/LayoutTests/svg/custom/bad-attributeName-crash.html 2014-05-09 10:58:14 UTC (rev 168524)
@@ -0,0 +1,14 @@
+<!DOCTYPE html>
+<html>
+ <body>
+ <script src=""
+
+ <script>
+ description("Tests that we do not crash on a bad attribute name.");
+ </script>
+
+ <svg>
+ <set attributeName="`:"></set>
+ </svg>
+ </body>
+</html>
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (168523 => 168524)
--- trunk/Source/WebCore/ChangeLog 2014-05-09 07:10:41 UTC (rev 168523)
+++ trunk/Source/WebCore/ChangeLog 2014-05-09 10:58:14 UTC (rev 168524)
@@ -1,3 +1,25 @@
+2014-05-09 Martin Hodovan <mhodo...@inf.u-szeged.hu>
+
+ ASSERTION FAILED: !m_code || m_code == defaultExceptionCode
+ in WebCore::constructQualifiedName
+ https://bugs.webkit.org/show_bug.cgi?id=132343
+
+ 'Remove bad assertion in SVGSMILElement's constructQualifiedName() by passing
+ IGNORE_EXCEPTION instead ASSERT_NO_EXCEPTION to Document::parseQualifiedName().
+ The constructQualifiedName() function handles parseQualifiedName() failures
+ propertly by returning early so there is no reason to assert on parsing
+ failures.'
+
+ Blink merge: http://src.chromium.org/viewvc/blink?view=revision&revision=173564
+ Based on the patch made by Christophe Dumez <ch.du...@samsung.com>.
+
+ Reviewed by Dirk Schulze.
+
+ Test: svg/custom/bad-attributeName-crash.html
+
+ * svg/animation/SVGSMILElement.cpp:
+ (WebCore::constructQualifiedName):
+
2014-05-08 Brent Fulgham <bfulg...@apple.com>
Multiple (stacked) cues when shuttling through video while playing closed captions
Modified: trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp (168523 => 168524)
--- trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp 2014-05-09 07:10:41 UTC (rev 168523)
+++ trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp 2014-05-09 10:58:14 UTC (rev 168524)
@@ -197,7 +197,7 @@
String prefix;
String localName;
- if (!Document::parseQualifiedName(attributeName, prefix, localName, ASSERT_NO_EXCEPTION))
+ if (!Document::parseQualifiedName(attributeName, prefix, localName, IGNORE_EXCEPTION))
return anyQName();
String namespaceURI = svgElement->lookupNamespaceURI(prefix);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
