Title: [168562] trunk/Source/WebKit2
- Revision
- 168562
- Author
- simon.fra...@apple.com
- Date
- 2014-05-09 18:10:06 -0700 (Fri, 09 May 2014)
Log Message
Fix some issues with scrolling tree logging
https://bugs.webkit.org/show_bug.cgi?id=132762
Reviewed by Tim Horton.
Only dump viewport constraints when they change, and dump the primary layer on
scrolling nodes.
* Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingTreeTextStream::dump): Dump the primary layer.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (168561 => 168562)
--- trunk/Source/WebKit2/ChangeLog 2014-05-10 00:38:09 UTC (rev 168561)
+++ trunk/Source/WebKit2/ChangeLog 2014-05-10 01:10:06 UTC (rev 168562)
@@ -1,5 +1,18 @@
2014-05-09 Simon Fraser <simon.fra...@apple.com>
+ Fix some issues with scrolling tree logging
+ https://bugs.webkit.org/show_bug.cgi?id=132762
+
+ Reviewed by Tim Horton.
+
+ Only dump viewport constraints when they change, and dump the primary layer on
+ scrolling nodes.
+
+ * Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
+ (WebKit::RemoteScrollingTreeTextStream::dump): Dump the primary layer.
+
+2014-05-09 Simon Fraser <simon.fra...@apple.com>
+
[iOS WK2] Fixed elements can go outside the document on pinching
https://bugs.webkit.org/show_bug.cgi?id=132759
<rdar://problem/16870835>
Modified: trunk/Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp (168561 => 168562)
--- trunk/Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp 2014-05-10 00:38:09 UTC (rev 168561)
+++ trunk/Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp 2014-05-10 01:10:06 UTC (rev 168562)
@@ -463,6 +463,9 @@
dumpProperty(ts, "type", node.nodeType());
+ if (!changedPropertiesOnly || node.hasChangedProperty(ScrollingStateNode::ScrollLayer))
+ dumpProperty(ts, "layer", static_cast<GraphicsLayer::PlatformLayerID>(node.layer()));
+
switch (node.nodeType()) {
case FrameScrollingNode:
case OverflowScrollingNode:
@@ -536,14 +539,16 @@
{
RemoteScrollingTreeTextStream& ts = *this;
- ts << node.viewportConstraints();
+ if (!changedPropertiesOnly || node.hasChangedProperty(ScrollingStateFixedNode::ViewportConstraints))
+ ts << node.viewportConstraints();
}
void RemoteScrollingTreeTextStream::dump(const ScrollingStateStickyNode& node, bool changedPropertiesOnly)
{
RemoteScrollingTreeTextStream& ts = *this;
- ts << node.viewportConstraints();
+ if (!changedPropertiesOnly || node.hasChangedProperty(ScrollingStateFixedNode::ViewportConstraints))
+ ts << node.viewportConstraints();
}
void RemoteScrollingTreeTextStream::recursiveDumpNodes(const ScrollingStateNode& node, bool changedPropertiesOnly)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
