Title: [169485] trunk/Tools
- Revision
- 169485
- Author
- mario.pr...@samsung.com
- Date
- 2014-05-30 08:20:26 -0700 (Fri, 30 May 2014)
Log Message
[ATK] Deprecate usage of logAccessibilityEvents() in layout tests
https://bugs.webkit.org/show_bug.cgi?id=132280
Rubber stamped by Carlos Garcia Campos.
Fix two small issues with previous patch (r169483), that caused some tests to break.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
duplicated entry.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (169484 => 169485)
--- trunk/Tools/ChangeLog 2014-05-30 14:16:54 UTC (rev 169484)
+++ trunk/Tools/ChangeLog 2014-05-30 15:20:26 UTC (rev 169485)
@@ -1,3 +1,18 @@
+2014-05-30 Mario Sanchez Prada <mario.pr...@samsung.com>
+
+ [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=132280
+
+ Rubber stamped by Carlos Garcia Campos.
+
+ Fix two small issues with previous patch (r169483), that caused some tests to break.
+
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
+ (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
+ duplicated entry.
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+ (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
+
2014-05-30 Jarek Czekalski <jarekc...@poczta.onet.pl>
[ATK] Added new accessibility signal: text-caret-moved.
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp (169484 => 169485)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp 2014-05-30 14:16:54 UTC (rev 169484)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp 2014-05-30 15:20:26 UTC (rev 169485)
@@ -251,7 +251,6 @@
const char* signalNames[] = {
"ATK:AtkObject:state-change",
- "ATK:AtkObject:state-change",
"ATK:AtkObject:focus-event",
"ATK:AtkObject:active-descendant-changed",
"ATK:AtkObject:children-changed",
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (169484 => 169485)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2014-05-30 14:16:54 UTC (rev 169484)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2014-05-30 15:20:26 UTC (rev 169485)
@@ -1585,7 +1585,7 @@
if (!ATK_IS_TEXT(m_element.get()))
return false;
- if (length)
+ if (!length)
return atk_text_set_caret_offset(ATK_TEXT(m_element.get()), location);
return atk_text_set_selection(ATK_TEXT(m_element.get()), 0, location, location + length);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
