Title: [170487] trunk/Source/WebCore
- Revision
- 170487
- Author
- [email protected]
- Date
- 2014-06-26 11:32:57 -0700 (Thu, 26 Jun 2014)
Log Message
[iOS]: Tapping <button> outside of a form is no longer working
https://bugs.webkit.org/show_bug.cgi?id=134319
<rdar://problem/17213346>
Reviewed by Daniel Bates.
Restore behavior of allowing <button> clicks outside of <form>.
This used to be iOS behavior before it was removed in favor of the
OpenSource (Android?) behavior. Now, willRespondToMouseClickEvents
is only used by iOS, so lets restore the iOS behavior.
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (170486 => 170487)
--- trunk/Source/WebCore/ChangeLog 2014-06-26 18:31:36 UTC (rev 170486)
+++ trunk/Source/WebCore/ChangeLog 2014-06-26 18:32:57 UTC (rev 170487)
@@ -1,3 +1,19 @@
+2014-06-25 Joseph Pecoraro <[email protected]>
+
+ [iOS]: Tapping <button> outside of a form is no longer working
+ https://bugs.webkit.org/show_bug.cgi?id=134319
+ <rdar://problem/17213346>
+
+ Reviewed by Daniel Bates.
+
+ Restore behavior of allowing <button> clicks outside of <form>.
+ This used to be iOS behavior before it was removed in favor of the
+ OpenSource (Android?) behavior. Now, willRespondToMouseClickEvents
+ is only used by iOS, so lets restore the iOS behavior.
+
+ * html/HTMLButtonElement.cpp:
+ (WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
+
2014-06-26 Jer Noble <[email protected]>
Unreviewed build-fix. Remove unintentionial rename of MediaTime.h -> MediaTimeHash.h.
Modified: trunk/Source/WebCore/html/HTMLButtonElement.cpp (170486 => 170487)
--- trunk/Source/WebCore/html/HTMLButtonElement.cpp 2014-06-26 18:31:36 UTC (rev 170486)
+++ trunk/Source/WebCore/html/HTMLButtonElement.cpp 2014-06-26 18:32:57 UTC (rev 170487)
@@ -154,9 +154,7 @@
bool HTMLButtonElement::willRespondToMouseClickEvents()
{
- if (!isDisabledFormControl() && form() && (m_type == SUBMIT || m_type == RESET))
- return true;
- return HTMLFormControlElement::willRespondToMouseClickEvents();
+ return !isDisabledFormControl();
}
bool HTMLButtonElement::isSuccessfulSubmitButton() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
