Title: [170497] trunk/Source/WebInspectorUI
Revision
170497
Author
jonowe...@apple.com
Date
2014-06-26 15:15:43 -0700 (Thu, 26 Jun 2014)

Log Message

Web Inspector: Command-/ (slash) now auto-comments code via CodeMirror 4. Should remove as command to pause
https://bugs.webkit.org/show_bug.cgi?id=134313

Reviewed by Timothy Hatcher.

Changed alternate command to pause/resume from command-slash to command-backslash.
Command-slash sets/unsets comments in all code editors.

* UserInterface/Models/KeyboardShortcut.js: Added Backslash.
* UserInterface/Views/DebuggerSidebarPanel.js: Changed pauseOrResumeAlternateKeyboardShortcut to use Backslash instead of Slash.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (170496 => 170497)


--- trunk/Source/WebInspectorUI/ChangeLog	2014-06-26 22:12:41 UTC (rev 170496)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-06-26 22:15:43 UTC (rev 170497)
@@ -1,3 +1,16 @@
+2014-06-26  Jono Wells  <jonowe...@apple.com>
+
+        Web Inspector: Command-/ (slash) now auto-comments code via CodeMirror 4. Should remove as command to pause
+        https://bugs.webkit.org/show_bug.cgi?id=134313
+
+        Reviewed by Timothy Hatcher.
+
+        Changed alternate command to pause/resume from command-slash to command-backslash.
+        Command-slash sets/unsets comments in all code editors.
+
+        * UserInterface/Models/KeyboardShortcut.js: Added Backslash.
+        * UserInterface/Views/DebuggerSidebarPanel.js: Changed pauseOrResumeAlternateKeyboardShortcut to use Backslash instead of Slash.
+
 2014-06-25  Jono Wells  <jonowe...@apple.com>
 
         Web Inspector: Rules panel's strikethrough gets confused at -webkit-align-items: flex-start;

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/KeyboardShortcut.js (170496 => 170497)


--- trunk/Source/WebInspectorUI/UserInterface/Models/KeyboardShortcut.js	2014-06-26 22:12:41 UTC (rev 170496)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/KeyboardShortcut.js	2014-06-26 22:15:43 UTC (rev 170497)
@@ -154,6 +154,7 @@
     Minus: new WebInspector.Key(189, "-"),
     Period: new WebInspector.Key(190, "."),
     Slash: new WebInspector.Key(191, "/"),
+    Backslash: new WebInspector.Key(220, "\\"),
     Apostrophe: new WebInspector.Key(192, "`"),
     SingleQuote: new WebInspector.Key(222, "\'")
 };

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (170496 => 170497)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js	2014-06-26 22:12:41 UTC (rev 170496)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js	2014-06-26 22:15:43 UTC (rev 170497)
@@ -45,7 +45,7 @@
     this._stepIntoKeyboardShortcut = new WebInspector.KeyboardShortcut(null, WebInspector.KeyboardShortcut.Key.F7, this._debuggerStepIntoButtonClicked.bind(this));
     this._stepOutKeyboardShortcut = new WebInspector.KeyboardShortcut(null, WebInspector.KeyboardShortcut.Key.F8, this._debuggerStepOutButtonClicked.bind(this));
 
-    this.pauseOrResumeAlternateKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, WebInspector.KeyboardShortcut.Key.Slash, this._debuggerPauseResumeButtonClicked.bind(this));
+    this.pauseOrResumeAlternateKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, WebInspector.KeyboardShortcut.Key.Backslash, this._debuggerPauseResumeButtonClicked.bind(this));
     this._stepOverAlternateKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, WebInspector.KeyboardShortcut.Key.SingleQuote, this._debuggerStepOverButtonClicked.bind(this));
     this._stepIntoAlternateKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, WebInspector.KeyboardShortcut.Key.Semicolon, this._debuggerStepIntoButtonClicked.bind(this));
     this._stepOutAlternateKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Shift | WebInspector.KeyboardShortcut.Modifier.CommandOrControl, WebInspector.KeyboardShortcut.Key.Semicolon, this._debuggerStepOutButtonClicked.bind(this));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to