Title: [170552] trunk/Source/WebKit/mac
Revision
170552
Author
wei...@apple.com
Date
2014-06-27 14:04:16 -0700 (Fri, 27 Jun 2014)

Log Message

InfoClick (from Nisus Software) dies on viewing found items
<rdar://problem/17395601>
https://bugs.webkit.org/show_bug.cgi?id=134410

Reviewed by Andy Estes.

InfoClick was calling -[WebPreferences setPrivateBrowsingEnabled:] before
setting up a WebView (or anything else that would have set up WebKitSystemInterface),
which now requires a set up WebKitSystemInterface. We can fix this by initializing
it from +[WebPreferences initialize].

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Add call to InitWebCoreSystemInterface().

(+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
Remove now unnecessary call to InitWebCoreSystemInterface().

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (170551 => 170552)


--- trunk/Source/WebKit/mac/ChangeLog	2014-06-27 20:53:14 UTC (rev 170551)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-06-27 21:04:16 UTC (rev 170552)
@@ -1,3 +1,23 @@
+2014-06-27  Sam Weinig  <s...@webkit.org>
+
+        InfoClick (from Nisus Software) dies on viewing found items
+        <rdar://problem/17395601>
+        https://bugs.webkit.org/show_bug.cgi?id=134410
+
+        Reviewed by Andy Estes.
+
+        InfoClick was calling -[WebPreferences setPrivateBrowsingEnabled:] before
+        setting up a WebView (or anything else that would have set up WebKitSystemInterface),
+        which now requires a set up WebKitSystemInterface. We can fix this by initializing
+        it from +[WebPreferences initialize].
+
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]):
+        Add call to InitWebCoreSystemInterface().
+
+        (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
+        Remove now unnecessary call to InitWebCoreSystemInterface().
+
 2014-06-27  Peyton Randolph  <prando...@apple.com>
 
         Add feature flag for link long-press gesture.

Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (170551 => 170552)


--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm	2014-06-27 20:53:14 UTC (rev 170551)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm	2014-06-27 21:04:16 UTC (rev 170552)
@@ -394,6 +394,7 @@
     WTF::initializeMainThreadToProcessMainThread();
     RunLoop::initializeMainRunLoop();
 #endif
+    InitWebCoreSystemInterface();
 
     NSDictionary *dict = [NSDictionary dictionaryWithObjectsAndKeys:
         @"Times",                       WebKitStandardFontPreferenceKey,
@@ -1781,7 +1782,6 @@
 
 + (void)_switchNetworkLoaderToNewTestingSession
 {
-    InitWebCoreSystemInterface();
     NetworkStorageSession::switchToNewTestingSession();
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to