Title: [170859] trunk/Source/WebKit2
Revision
170859
Author
timothy_hor...@apple.com
Date
2014-07-07 16:18:21 -0700 (Mon, 07 Jul 2014)

Log Message

Nearly everything in the UIProcess "leaks" when WKWebView is torn down
https://bugs.webkit.org/show_bug.cgi?id=134699
<rdar://problem/17581777>

Reviewed by Simon Fraser.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
Adoption is important!

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (170858 => 170859)


--- trunk/Source/WebKit2/ChangeLog	2014-07-07 21:42:53 UTC (rev 170858)
+++ trunk/Source/WebKit2/ChangeLog	2014-07-07 23:18:21 UTC (rev 170859)
@@ -1,3 +1,15 @@
+2014-07-07  Tim Horton  <timothy_hor...@apple.com>
+
+        Nearly everything in the UIProcess "leaks" when WKWebView is torn down
+        https://bugs.webkit.org/show_bug.cgi?id=134699
+        <rdar://problem/17581777>
+
+        Reviewed by Simon Fraser.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView initWithFrame:configuration:]):
+        Adoption is important!
+
 2014-07-07  Enrica Casucci  <enr...@apple.com>
 
         REGRESSION(iOS WK2): arrow keys movements don't work.

Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (170858 => 170859)


--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-07-07 21:42:53 UTC (rev 170858)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-07-07 23:18:21 UTC (rev 170859)
@@ -305,7 +305,7 @@
 #endif
 
 #if PLATFORM(MAC)
-    _wkView = [[WKView alloc] initWithFrame:bounds context:context configuration:WTF::move(webPageConfiguration) webView:self];
+    _wkView = adoptNS([[WKView alloc] initWithFrame:bounds context:context configuration:WTF::move(webPageConfiguration) webView:self]);
     [self addSubview:_wkView.get()];
     _page = WebKit::toImpl([_wkView pageRef]);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to