Title: [170931] trunk/Source/WebKit/mac
- Revision
- 170931
- Author
- rn...@webkit.org
- Date
- 2014-07-09 14:36:16 -0700 (Wed, 09 Jul 2014)
Log Message
REGRESSION(r167770): Cannot login in Evernote Safari extension
https://bugs.webkit.org/show_bug.cgi?id=134776
Reviewed by Enrica Casucci.
Unfortunately, NSWindowDidBecomeKeyNotification does not notify us when a popover becomes key
so we need to keep using the SPI (_windowChangedKeyState) I removed in r167770.
* WebView/WebView.mm:
(-[WebView _windowChangedKeyState]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (170930 => 170931)
--- trunk/Source/WebKit/mac/ChangeLog 2014-07-09 21:19:47 UTC (rev 170930)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-07-09 21:36:16 UTC (rev 170931)
@@ -1,3 +1,16 @@
+2014-07-09 Ryosuke Niwa <rn...@webkit.org>
+
+ REGRESSION(r167770): Cannot login in Evernote Safari extension
+ https://bugs.webkit.org/show_bug.cgi?id=134776
+
+ Reviewed by Enrica Casucci.
+
+ Unfortunately, NSWindowDidBecomeKeyNotification does not notify us when a popover becomes key
+ so we need to keep using the SPI (_windowChangedKeyState) I removed in r167770.
+
+ * WebView/WebView.mm:
+ (-[WebView _windowChangedKeyState]):
+
2014-07-09 Enrica Casucci <enr...@apple.com>
Implement Editor::fontAttributesForSelectionStart() or iOS.
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (170930 => 170931)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2014-07-09 21:19:47 UTC (rev 170930)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2014-07-09 21:36:16 UTC (rev 170931)
@@ -295,6 +295,7 @@
- (NSView *)_hitTest:(NSPoint *)aPoint dragTypes:(NSSet *)types;
- (void)_autoscrollForDraggingInfo:(id)dragInfo timeDelta:(NSTimeInterval)repeatDelta;
- (BOOL)_shouldAutoscrollForDraggingInfo:(id)dragInfo;
+- (void)_windowChangedKeyState;
@end
@interface NSWindow (WebNSWindowDetails)
@@ -5274,6 +5275,12 @@
_private->page->chrome().windowScreenDidChange((PlatformDisplayID)[[[[[self window] screen] deviceDescription] objectForKey:@"NSScreenNumber"] intValue]);
}
+- (void)_windowChangedKeyState
+{
+ [self _updateActiveState];
+ [super _windowChangedKeyState];
+}
+
- (void)windowKeyStateChanged:(NSNotification *)notification
{
[self _updateActiveState];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
