Title: [170951] trunk/Source/WebKit2
- Revision
- 170951
- Author
- commit-qu...@webkit.org
- Date
- 2014-07-09 21:13:37 -0700 (Wed, 09 Jul 2014)
Log Message
[EFL][WK2] Add new Public API in ewk_download_job.h to get size of the data already downloaded.
https://bugs.webkit.org/show_bug.cgi?id=134759
Patch by Shivakumar JM <shiva...@samsung.com> on 2014-07-09
Reviewed by Gyuyoung Kim.
Add new API in ewk_download_job.h to get size of the data already downloaded.
* UIProcess/API/efl/ewk_download_job.cpp:
(ewk_download_job_received_data_length_get):
(EwkDownloadJob::receivedData):
* UIProcess/API/efl/ewk_download_job.h:
* UIProcess/API/efl/ewk_download_job_private.h:
* UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
(EWK2DownloadJobTest::on_download_requested):
(EWK2DownloadJobTest::on_download_finished):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170950 => 170951)
--- trunk/Source/WebKit2/ChangeLog 2014-07-10 04:11:34 UTC (rev 170950)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-10 04:13:37 UTC (rev 170951)
@@ -1,3 +1,21 @@
+2014-07-09 Shivakumar JM <shiva...@samsung.com>
+
+ [EFL][WK2] Add new Public API in ewk_download_job.h to get size of the data already downloaded.
+ https://bugs.webkit.org/show_bug.cgi?id=134759
+
+ Reviewed by Gyuyoung Kim.
+
+ Add new API in ewk_download_job.h to get size of the data already downloaded.
+
+ * UIProcess/API/efl/ewk_download_job.cpp:
+ (ewk_download_job_received_data_length_get):
+ (EwkDownloadJob::receivedData):
+ * UIProcess/API/efl/ewk_download_job.h:
+ * UIProcess/API/efl/ewk_download_job_private.h:
+ * UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
+ (EWK2DownloadJobTest::on_download_requested):
+ (EWK2DownloadJobTest::on_download_finished):
+
2014-07-09 Enrica Casucci <enr...@apple.com>
REGRESSION(r170858): Safari freezes upon making a search on a website (yelp.com).
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.cpp (170950 => 170951)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.cpp 2014-07-10 04:11:34 UTC (rev 170950)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.cpp 2014-07-10 04:13:37 UTC (rev 170951)
@@ -203,6 +203,18 @@
return ecore_time_get() - m_startTime;
}
+uint64_t ewk_download_job_received_data_size_get(const Ewk_Download_Job* download)
+{
+ EWK_OBJ_GET_IMPL_OR_RETURN(const EwkDownloadJob, download, impl, 0);
+
+ return impl->receivedDataSize();
+}
+
+uint64_t EwkDownloadJob::receivedDataSize() const
+{
+ return m_downloaded;
+}
+
/**
* @internal
* Sets the URL @a response for this @a download.
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.h (170950 => 170951)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.h 2014-07-10 04:11:34 UTC (rev 170950)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.h 2014-07-10 04:13:37 UTC (rev 170951)
@@ -183,6 +183,18 @@
*/
EAPI double ewk_download_job_elapsed_time_get(const Ewk_Download_Job *download);
+/**
+ * Gets the data size, already downloaded.
+ *
+ * If the download finished, had an error or was cancelled this is
+ * the data size between its start and the end.
+ *
+ * @param download a #Ewk_Download_Job to query.
+ *
+ * @return the size of the data already downloaded, since the download was started or 0.0 in case of failure.
+ */
+EAPI uint64_t ewk_download_job_received_data_size_get(const Ewk_Download_Job *download);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h (170950 => 170951)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h 2014-07-10 04:11:34 UTC (rev 170950)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h 2014-07-10 04:13:37 UTC (rev 170951)
@@ -68,6 +68,7 @@
double estimatedProgress() const;
double elapsedTime() const;
void incrementReceivedData(uint64_t length);
+ uint64_t receivedDataSize() const;
private:
EwkDownloadJob(WKDownloadRef download, EwkView* view);
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp (170950 => 170951)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp 2014-07-10 04:11:34 UTC (rev 170950)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp 2014-07-10 04:13:37 UTC (rev 170951)
@@ -103,6 +103,7 @@
ASSERT_EQ(EWK_DOWNLOAD_JOB_STATE_NOT_STARTED, ewk_download_job_state_get(download));
ASSERT_EQ(0, ewk_download_job_estimated_progress_get(download));
ASSERT_EQ(0, ewk_download_job_elapsed_time_get(download));
+ ASSERT_EQ(0, ewk_download_job_received_data_size_get(download));
Ewk_Url_Request* request = ewk_download_job_request_get(download);
ASSERT_TRUE(request);
@@ -142,6 +143,7 @@
ASSERT_EQ(1, ewk_download_job_estimated_progress_get(download));
ASSERT_EQ(EWK_DOWNLOAD_JOB_STATE_FINISHED, ewk_download_job_state_get(download));
ASSERT_GT(ewk_download_job_elapsed_time_get(download), 0);
+ ASSERT_GT(ewk_download_job_received_data_size_get(download), 0);
ASSERT_TRUE(fileExists(testData->destinationPath));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
