Title: [171688] trunk/Source/_javascript_Core
Revision
171688
Author
commit-qu...@webkit.org
Date
2014-07-28 13:38:32 -0700 (Mon, 28 Jul 2014)

Log Message

JSContext Inspector: crash when using step-into
https://bugs.webkit.org/show_bug.cgi?id=135345

Patch by Joseph Pecoraro <pecor...@apple.com> on 2014-07-28
Reviewed by Timothy Hatcher.

* inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::stepInto):
Null check m_listener since it may not be set.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (171687 => 171688)


--- trunk/Source/_javascript_Core/ChangeLog	2014-07-28 20:03:45 UTC (rev 171687)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-07-28 20:38:32 UTC (rev 171688)
@@ -1,3 +1,14 @@
+2014-07-28  Joseph Pecoraro  <pecor...@apple.com>
+
+        JSContext Inspector: crash when using step-into
+        https://bugs.webkit.org/show_bug.cgi?id=135345
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/agents/InspectorDebuggerAgent.cpp:
+        (Inspector::InspectorDebuggerAgent::stepInto):
+        Null check m_listener since it may not be set.
+
 2014-07-28  Brian J. Burg  <b...@cs.washington.edu>
 
         Web Replay: auto-decoding of parameterized vector's elements is incorrect

Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp (171687 => 171688)


--- trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp	2014-07-28 20:03:45 UTC (rev 171687)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp	2014-07-28 20:38:32 UTC (rev 171688)
@@ -483,7 +483,9 @@
 
     m_injectedScriptManager->releaseObjectGroup(InspectorDebuggerAgent::backtraceObjectGroup);
     scriptDebugServer().stepIntoStatement();
-    m_listener->stepInto();
+
+    if (m_listener)
+        m_listener->stepInto();
 }
 
 void InspectorDebuggerAgent::stepOut(ErrorString* errorString)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to