Title: [171706] trunk/Source/WebKit2
- Revision
- 171706
- Author
- roger_f...@apple.com
- Date
- 2014-07-28 15:32:06 -0700 (Mon, 28 Jul 2014)
Log Message
Disable tagged strings for the plugin process.
https://bugs.webkit.org/show_bug.cgi?id=135354
<rdar://problem/17295639>.
Patch by Alexey Proskuryakov and Roger Fong.
Reviewed by Anders Carlsson.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToReExecService):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (171705 => 171706)
--- trunk/Source/WebKit2/ChangeLog 2014-07-28 22:29:37 UTC (rev 171705)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-28 22:32:06 UTC (rev 171706)
@@ -1,3 +1,17 @@
+2014-07-28 Roger Fong <roger_f...@apple.com>
+
+ Disable tagged strings for the plugin process.
+ https://bugs.webkit.org/show_bug.cgi?id=135354
+ <rdar://problem/17295639>.
+
+ Patch by Alexey Proskuryakov and Roger Fong.
+
+ Reviewed by Anders Carlsson.
+
+ * PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
+ * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+ (WebKit::connectToReExecService):
+
2014-07-25 Jeffrey Pfau <jp...@apple.com>
IDB transactions never reset if the Web Process ends before cleaning up
Modified: trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist (171705 => 171706)
--- trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist 2014-07-28 22:29:37 UTC (rev 171705)
+++ trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist 2014-07-28 22:32:06 UTC (rev 171706)
@@ -50,6 +50,8 @@
<dict>
<key>DYLD_INSERT_LIBRARIES</key>
<string>$(WEBKIT_FRAMEWORKS_DIR)/WebKit.framework/PluginProcess.app/Contents/MacOS/PluginProcessShim.dylib</string>
+ <key>NSStringDisableTagged</key>
+ <string>YES</string>
</dict>
</dict>
</dict>
Modified: trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm (171705 => 171706)
--- trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2014-07-28 22:29:37 UTC (rev 171705)
+++ trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2014-07-28 22:32:06 UTC (rev 171706)
@@ -290,6 +290,13 @@
EnvironmentVariables environmentVariables;
addDYLDEnvironmentAdditions(launchOptions, true, environmentVariables);
+#if ENABLE(NETSCAPE_PLUGIN_API)
+ if (launchOptions.processType == ProcessLauncher::PluginProcess) {
+ // Tagged pointers break video in Flash, see bug 135354.
+ environmentVariables.set("NSStringDisableTagged", "YES");
+ }
+#endif
+
// Generate the uuid for the service instance we are about to create.
// FIXME: This UUID should be stored on the ChildProcessProxy.
RefPtr<UUIDHolder> instanceUUID = UUIDHolder::create();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
