Title: [171710] trunk/Source/WebInspectorUI
- Revision
- 171710
- Author
- commit-qu...@webkit.org
- Date
- 2014-07-28 16:52:37 -0700 (Mon, 28 Jul 2014)
Log Message
Web Inspector: Disable Copy Row in Timelines DataGrids, it does not currently provide value
https://bugs.webkit.org/show_bug.cgi?id=135364
Patch by Joseph Pecoraro <pecor...@apple.com> on 2014-07-28
Reviewed by Timothy Hatcher.
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGridNode):
(WebInspector.DataGridNode.prototype.get copyable):
(WebInspector.DataGridNode.prototype.set copyable):
* UserInterface/Views/TimelineDataGridNode.js:
(WebInspector.TimelineDataGridNode):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (171709 => 171710)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-07-28 23:47:09 UTC (rev 171709)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-07-28 23:52:37 UTC (rev 171710)
@@ -1,3 +1,17 @@
+2014-07-28 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Disable Copy Row in Timelines DataGrids, it does not currently provide value
+ https://bugs.webkit.org/show_bug.cgi?id=135364
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGridNode):
+ (WebInspector.DataGridNode.prototype.get copyable):
+ (WebInspector.DataGridNode.prototype.set copyable):
+ * UserInterface/Views/TimelineDataGridNode.js:
+ (WebInspector.TimelineDataGridNode):
+
2014-07-26 Brian J. Burg <b...@cs.washington.edu>
Web Inspector: ReplayManager uses undefined events and inconsistent event data
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (171709 => 171710)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2014-07-28 23:47:09 UTC (rev 171709)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2014-07-28 23:52:37 UTC (rev 171710)
@@ -1129,7 +1129,7 @@
if (this.dataGrid._refreshCallback && (!gridNode || gridNode !== this.placeholderNode))
contextMenu.appendItem(WebInspector.UIString("Refresh"), this._refreshCallback.bind(this));
- if (gridNode && gridNode.selectable && !gridNode.isEventWithinDisclosureTriangle(event)) {
+ if (gridNode && gridNode.selectable && gridNode.copyable && !gridNode.isEventWithinDisclosureTriangle(event)) {
contextMenu.appendItem(WebInspector.UIString("Copy Row"), this._copyRow.bind(this, event.target));
if (this.dataGrid._editCallback) {
@@ -1312,6 +1312,7 @@
{
this._expanded = false;
this._selected = false;
+ this._copyable = true;
this._shouldRefreshChildren = true;
this._data = data || {};
this.hasChildren = hasChildren || false;
@@ -1329,6 +1330,16 @@
return !this._element || !this._element.classList.contains("hidden");
},
+ get copyable()
+ {
+ return this._copyable;
+ },
+
+ set copyable(x)
+ {
+ this._copyable = x;
+ },
+
get element()
{
if (this._element)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js (171709 => 171710)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js 2014-07-28 23:47:09 UTC (rev 171709)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js 2014-07-28 23:52:37 UTC (rev 171710)
@@ -27,6 +27,8 @@
{
WebInspector.DataGridNode.call(this, {}, hasChildren);
+ this.copyable = false;
+
this._graphOnly = graphOnly || false;
this._graphDataSource = graphDataSource || null;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
