Title: [171715] trunk/Source/WebKit2
Revision
171715
Author
mr...@apple.com
Date
2014-07-28 17:56:18 -0700 (Mon, 28 Jul 2014)

Log Message

Web process crash causes UI process to die with an assertion failure in Connection::exceptionSourceEventHandler
https://bugs.webkit.org/show_bug.cgi?id=135366

Reviewed by Dan Bernstein.

* Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::exceptionSourceEventHandler): Remove the assertion since it frequently fires during
normal development with debug builds.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (171714 => 171715)


--- trunk/Source/WebKit2/ChangeLog	2014-07-29 00:51:37 UTC (rev 171714)
+++ trunk/Source/WebKit2/ChangeLog	2014-07-29 00:56:18 UTC (rev 171715)
@@ -1,3 +1,14 @@
+2014-07-28  Mark Rowe  <mr...@apple.com>
+
+        Web process crash causes UI process to die with an assertion failure in Connection::exceptionSourceEventHandler
+        https://bugs.webkit.org/show_bug.cgi?id=135366
+
+        Reviewed by Dan Bernstein.
+
+        * Platform/IPC/mac/ConnectionMac.mm:
+        (IPC::Connection::exceptionSourceEventHandler): Remove the assertion since it frequently fires during
+        normal development with debug builds.
+
 2014-07-28  Benjamin Poulain  <bpoul...@apple.com>
 
         [iOS WK2] WKWebView sometime tries to change the size of a null DrawingAreaProxy

Modified: trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm (171714 => 171715)


--- trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm	2014-07-29 00:51:37 UTC (rev 171714)
+++ trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm	2014-07-29 00:56:18 UTC (rev 171715)
@@ -553,10 +553,8 @@
 
     // Now send along the message.
     kern_return_t kr = mach_msg(header, MACH_SEND_MSG, header->msgh_size, 0, MACH_PORT_NULL, MACH_MSG_TIMEOUT_NONE, MACH_PORT_NULL);
-    if (kr != KERN_SUCCESS) {
+    if (kr != KERN_SUCCESS)
         LOG_ERROR("Failed to send message to real exception port. %s (%x)", mach_error_string(kr), kr);
-        ASSERT_NOT_REACHED();
-    }
 
     connectionDidClose();
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to