Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (171745 => 171746)
--- trunk/Source/_javascript_Core/ChangeLog 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-07-29 15:47:39 UTC (rev 171746)
@@ -1,3 +1,15 @@
+2014-07-29 Daniel Bates <daba...@apple.com>
+
+ Use WTF::move() instead of std::move() to help ensure move semantics
+ https://bugs.webkit.org/show_bug.cgi?id=135351
+
+ Reviewed by Alexey Proskuryakov.
+
+ * bytecode/GetByIdStatus.cpp:
+ (JSC::GetByIdStatus::computeForStubInfo):
+ * bytecode/GetByIdVariant.cpp:
+ (JSC::GetByIdVariant::GetByIdVariant):
+
2014-07-28 Tamas Gergely <tgergely.u-sze...@partner.samsung.com>
BuildFix: _javascript_Core/bytecode/StructureSet.h:262:77: warning.
Modified: trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp (171745 => 171746)
--- trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp 2014-07-29 15:47:39 UTC (rev 171746)
@@ -253,7 +253,7 @@
GetByIdVariant variant(
StructureSet(structure), myOffset, specificValue, chain.get(),
- std::move(callLinkStatus));
+ WTF::move(callLinkStatus));
if (!result.appendVariant(variant))
return GetByIdStatus(slowPathState, true);
Modified: trunk/Source/_javascript_Core/bytecode/GetByIdVariant.cpp (171745 => 171746)
--- trunk/Source/_javascript_Core/bytecode/GetByIdVariant.cpp 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/_javascript_Core/bytecode/GetByIdVariant.cpp 2014-07-29 15:47:39 UTC (rev 171746)
@@ -39,7 +39,7 @@
, m_alternateBase(nullptr)
, m_specificValue(specificValue)
, m_offset(offset)
- , m_callLinkStatus(std::move(callLinkStatus))
+ , m_callLinkStatus(WTF::move(callLinkStatus))
{
if (!structureSet.size()) {
ASSERT(offset == invalidOffset);
Modified: trunk/Source/WTF/ChangeLog (171745 => 171746)
--- trunk/Source/WTF/ChangeLog 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WTF/ChangeLog 2014-07-29 15:47:39 UTC (rev 171746)
@@ -1,3 +1,13 @@
+2014-07-29 Daniel Bates <daba...@apple.com>
+
+ Use WTF::move() instead of std::move() to help ensure move semantics
+ https://bugs.webkit.org/show_bug.cgi?id=135351
+
+ Reviewed by Alexey Proskuryakov.
+
+ * wtf/HashTable.h:
+ (WTF::KeyTraits>::HashTable):
+
2014-07-28 Brian J. Burg <b...@cs.washington.edu>
Should not export symbols for base64Encode inline adapter methods
Modified: trunk/Source/WTF/wtf/HashTable.h (171745 => 171746)
--- trunk/Source/WTF/wtf/HashTable.h 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WTF/wtf/HashTable.h 2014-07-29 15:47:39 UTC (rev 171746)
@@ -1225,7 +1225,7 @@
other.m_deletedCount = 0;
#if DUMP_HASHTABLE_STATS_PER_TABLE
- m_stats = std::move(other.m_stats);
+ m_stats = WTF::move(other.m_stats);
other.m_stats = nullptr;
#endif
}
@@ -1249,7 +1249,7 @@
other.m_deletedCount = 0;
#if DUMP_HASHTABLE_STATS_PER_TABLE
- m_stats = std::move(other.m_stats);
+ m_stats = WTF::move(other.m_stats);
other.m_stats = nullptr;
#endif
Modified: trunk/Source/WebCore/ChangeLog (171745 => 171746)
--- trunk/Source/WebCore/ChangeLog 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WebCore/ChangeLog 2014-07-29 15:47:39 UTC (rev 171746)
@@ -1,3 +1,13 @@
+2014-07-29 Daniel Bates <daba...@apple.com>
+
+ Use WTF::move() instead of std::move() to help ensure move semantics
+ https://bugs.webkit.org/show_bug.cgi?id=135351
+
+ Reviewed by Alexey Proskuryakov.
+
+ * page/CaptionUserPreferences.cpp:
+ (WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride):
+
2014-07-29 Mihnea Ovidenie <mih...@adobe.com>
[CSSRegions] Assertion failure hit testing a region-based multicolumn in a region
Modified: trunk/Source/WebCore/page/CaptionUserPreferences.cpp (171745 => 171746)
--- trunk/Source/WebCore/page/CaptionUserPreferences.cpp 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WebCore/page/CaptionUserPreferences.cpp 2014-07-29 15:47:39 UTC (rev 171746)
@@ -253,7 +253,7 @@
for (auto& page : pages) {
if (auto* pageUserContentController = page->userContentController()) {
auto userStyleSheet = std::make_unique<UserStyleSheet>(captionsOverrideStyleSheet, captionsStyleSheetURL, Vector<String>(), Vector<String>(), InjectInAllFrames, UserStyleAuthorLevel);
- pageUserContentController->addUserStyleSheet(mainThreadNormalWorld(), std::move(userStyleSheet), InjectInExistingDocuments);
+ pageUserContentController->addUserStyleSheet(mainThreadNormalWorld(), WTF::move(userStyleSheet), InjectInExistingDocuments);
}
}
}
Modified: trunk/Source/WebKit2/ChangeLog (171745 => 171746)
--- trunk/Source/WebKit2/ChangeLog 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-29 15:47:39 UTC (rev 171746)
@@ -1,3 +1,17 @@
+2014-07-29 Daniel Bates <daba...@apple.com>
+
+ Use WTF::move() instead of std::move() to help ensure move semantics
+ https://bugs.webkit.org/show_bug.cgi?id=135351
+
+ Reviewed by Alexey Proskuryakov.
+
+ * UIProcess/API/Cocoa/_WKSessionState.mm:
+ (-[_WKSessionState _initWithSessionState:]):
+ * UIProcess/API/gtk/WebKitUserContent.cpp:
+ (toStringVector): Remove use of std::move(). It's unnecessary to call std::move() on an rvalue.
+ * WebProcess/WebPage/mac/ServicesOverlayController.mm:
+ (WebKit::ServicesOverlayController::mouseEvent):
+
2014-07-28 Pratik Solanki <psola...@apple.com>
Get SharedBuffer.h out of ResourceBuffer.h (and a few other places)
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKSessionState.mm (171745 => 171746)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKSessionState.mm 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKSessionState.mm 2014-07-29 15:47:39 UTC (rev 171746)
@@ -50,7 +50,7 @@
if (!(self = [super init]))
return nil;
- _sessionState = std::move(sessionState);
+ _sessionState = WTF::move(sessionState);
return self;
}
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUserContent.cpp (171745 => 171746)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUserContent.cpp 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUserContent.cpp 2014-07-29 15:47:39 UTC (rev 171746)
@@ -70,7 +70,7 @@
Vector<String> result;
for (auto str = strv; *str; ++str)
- result.append(std::move(String::fromUTF8(*str)));
+ result.append(String::fromUTF8(*str));
return result;
}
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm (171745 => 171746)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm 2014-07-29 15:47:39 UTC (rev 171746)
@@ -460,7 +460,7 @@
// Check and see if the mouse went up and we have a current mouse down highlight button.
if (event.type() == WebEvent::MouseUp) {
- RetainPtr<DDHighlightRef> mouseDownHighlight = std::move(m_currentMouseDownOnButtonHighlight);
+ RetainPtr<DDHighlightRef> mouseDownHighlight = WTF::move(m_currentMouseDownOnButtonHighlight);
// If the mouse lifted while still over the highlight button that it went down on, then that is a click.
if (onButton && mouseDownHighlight) {
