Title: [171772] trunk
- Revision
- 171772
- Author
- a...@apple.com
- Date
- 2014-07-29 15:41:19 -0700 (Tue, 29 Jul 2014)
Log Message
fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
https://bugs.webkit.org/show_bug.cgi?id=135398
Reviewed by Zalan Bujtas.
Tools:
* WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
"hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
* DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
sure why.
LayoutTests:
* platform/mac-wk2/TestExpectations: Let's try to unskip the test, maybe this was
the actual reason for it to appear failing?
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (171771 => 171772)
--- trunk/LayoutTests/ChangeLog 2014-07-29 22:41:12 UTC (rev 171771)
+++ trunk/LayoutTests/ChangeLog 2014-07-29 22:41:19 UTC (rev 171772)
@@ -1,3 +1,13 @@
+2014-07-29 Alexey Proskuryakov <a...@apple.com>
+
+ fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
+ https://bugs.webkit.org/show_bug.cgi?id=135398
+
+ Reviewed by Zalan Bujtas.
+
+ * platform/mac-wk2/TestExpectations: Let's try to unskip the test, maybe this was
+ the actual reason for it to appear failing?
+
2014-07-29 Mihnea Ovidenie <mih...@adobe.com>
[CSSRegions] Assertion failure hit testing a region-based multicolumn in a region
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (171771 => 171772)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-07-29 22:41:12 UTC (rev 171771)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-07-29 22:41:19 UTC (rev 171772)
@@ -297,7 +297,6 @@
webkit.org/b/130175 [ MountainLion Debug ] compositing/hidpi-transform-with-render-layer-on-fractional-pixel-value.html [ ImageOnlyFailure ]
webkit.org/b/130175 [ MountainLion Debug ] compositing/hidpi-nested-compositing-layers-with-subpixel-accumulation.html [ ImageOnlyFailure ]
webkit.org/b/130175 [ MountainLion Debug ] compositing/hidpi-box-positioned-off-by-one-when-non-compositing-transform-is-present.html [ ImageOnlyFailure ]
-webkit.org/b/130175 [ MountainLion ] fast/borders/border-radius-on-subpixel-position-non-hidpi.html [ Pass ImageOnlyFailure ]
# Only failing on WK1
webkit.org/b/104104 fast/overflow/scrollbar-click-retains-focus.html [ Pass ]
Modified: trunk/Tools/ChangeLog (171771 => 171772)
--- trunk/Tools/ChangeLog 2014-07-29 22:41:12 UTC (rev 171771)
+++ trunk/Tools/ChangeLog 2014-07-29 22:41:19 UTC (rev 171772)
@@ -1,5 +1,19 @@
2014-07-29 Alexey Proskuryakov <a...@apple.com>
+ fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
+ https://bugs.webkit.org/show_bug.cgi?id=135398
+
+ Reviewed by Zalan Bujtas.
+
+ * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
+ "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
+ For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
+ sure why.
+
+2014-07-29 Alexey Proskuryakov <a...@apple.com>
+
PPT: run-webkit-tests doesn't upload crash logs to bots
https://bugs.webkit.org/show_bug.cgi?id=135391
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (171771 => 171772)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2014-07-29 22:41:12 UTC (rev 171771)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2014-07-29 22:41:19 UTC (rev 171772)
@@ -1467,7 +1467,7 @@
{
bool hasHighDPIWindow = [[[mainFrame webView] window] backingScaleFactor] != 1;
WTF::String localPathOrUrl = String(testPathOrUR);
- bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("hidpi-") != notFound;
+ bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("/hidpi-") != notFound;
if (hasHighDPIWindow == needsHighDPIWindow)
return;
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (171771 => 171772)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2014-07-29 22:41:12 UTC (rev 171771)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2014-07-29 22:41:19 UTC (rev 171772)
@@ -680,7 +680,7 @@
void TestController::updateWindowScaleForTest(const TestInvocation& test)
{
WTF::String localPathOrUrl = String(test.pathOrURL());
- bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("hidpi-") != notFound;
+ bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("/hidpi-") != notFound;
mainWebView()->changeWindowScaleIfNeeded(needsHighDPIWindow ? 2 : 1);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
