Title: [171829] trunk/Source/WebKit2
Revision
171829
Author
[email protected]
Date
2014-07-30 19:19:43 -0700 (Wed, 30 Jul 2014)

Log Message

REGRESSION (WK2 iOS): Inline editing for Chinese and Japanese keyboards does not work in Safari.
https://bugs.webkit.org/show_bug.cgi?id=135449
<rdar://problem/17824833>

Reviewed by Benjamin Poulain.

The WebProcess sends the notification that the gesture modified the phrase boundary,
but the flag was not being converted properly, therefore we failed to notify
the text input system that a change had occurred.

* UIProcess/ios/WKContentViewInteraction.mm:
(toUIWKSelectionFlags):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (171828 => 171829)


--- trunk/Source/WebKit2/ChangeLog	2014-07-31 01:48:56 UTC (rev 171828)
+++ trunk/Source/WebKit2/ChangeLog	2014-07-31 02:19:43 UTC (rev 171829)
@@ -1,3 +1,18 @@
+2014-07-30  Enrica Casucci  <[email protected]>
+
+        REGRESSION (WK2 iOS): Inline editing for Chinese and Japanese keyboards does not work in Safari.
+        https://bugs.webkit.org/show_bug.cgi?id=135449
+        <rdar://problem/17824833>
+
+        Reviewed by Benjamin Poulain.
+
+        The WebProcess sends the notification that the gesture modified the phrase boundary,
+        but the flag was not being converted properly, therefore we failed to notify
+        the text input system that a change had occurred.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (toUIWKSelectionFlags):
+
 2014-07-30  Andy Estes  <[email protected]>
 
         USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)

Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (171828 => 171829)


--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2014-07-31 01:48:56 UTC (rev 171828)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2014-07-31 02:19:43 UTC (rev 171829)
@@ -1618,6 +1618,8 @@
         uiFlags |= UIWKWordIsNearTap;
     if (flags & IsBlockSelection)
         uiFlags |= UIWKIsBlockSelection;
+    if (flags & PhraseBoundaryChanged)
+        uiFlags |= UIWKPhraseBoundaryChanged;
 
     return static_cast<UIWKSelectionFlags>(uiFlags);
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to