Title: [171895] trunk/Source/WebCore
- Revision
- 171895
- Author
- [email protected]
- Date
- 2014-07-31 16:52:19 -0700 (Thu, 31 Jul 2014)
Log Message
[iOS] Video in an <embed> has a bad aspect ratio when in fullscreen mode.
https://bugs.webkit.org/show_bug.cgi?id=135481
Reviewed by Simon Fraser.
Do not change the gravity of our AVPlayerLayer when in full screen mode; its gravity
is controlled by setVideoFullscreenGravity(), and should not be affected by style changes.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (171894 => 171895)
--- trunk/Source/WebCore/ChangeLog 2014-07-31 23:17:15 UTC (rev 171894)
+++ trunk/Source/WebCore/ChangeLog 2014-07-31 23:52:19 UTC (rev 171895)
@@ -1,3 +1,16 @@
+2014-07-31 Jer Noble <[email protected]>
+
+ [iOS] Video in an <embed> has a bad aspect ratio when in fullscreen mode.
+ https://bugs.webkit.org/show_bug.cgi?id=135481
+
+ Reviewed by Simon Fraser.
+
+ Do not change the gravity of our AVPlayerLayer when in full screen mode; its gravity
+ is controlled by setVideoFullscreenGravity(), and should not be affected by style changes.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):
+
2014-07-31 Beth Dakin <[email protected]>
Hit-testing broken in WebKit 1 views with AppKit's contentInsets
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (171894 => 171895)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-07-31 23:17:15 UTC (rev 171894)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-07-31 23:52:19 UTC (rev 171895)
@@ -1569,6 +1569,13 @@
if (!m_videoLayer)
return;
+#if PLATFORM(IOS)
+ // Do not attempt to change the video gravity while in full screen mode.
+ // See setVideoFullscreenGravity().
+ if (m_videoFullscreenLayer)
+ return;
+#endif
+
[CATransaction begin];
[CATransaction setDisableActions:YES];
NSString* gravity = shouldMaintainAspectRatio() ? AVLayerVideoGravityResizeAspect : AVLayerVideoGravityResize;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
