Title: [171937] trunk/Source/WebCore
- Revision
- 171937
- Author
- [email protected]
- Date
- 2014-08-01 11:53:38 -0700 (Fri, 01 Aug 2014)
Log Message
[MSE][Mac] Volume is not remembered between items in a YouTube playlist
https://bugs.webkit.org/show_bug.cgi?id=135479
Reviewed by Eric Carlson.
When an AVSampleBufferAudioRenderer is added to the player, set its -volume and -muted
properties with the current values from the HTMLMediaElement.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (171936 => 171937)
--- trunk/Source/WebCore/ChangeLog 2014-08-01 18:50:05 UTC (rev 171936)
+++ trunk/Source/WebCore/ChangeLog 2014-08-01 18:53:38 UTC (rev 171937)
@@ -1,3 +1,16 @@
+2014-08-01 Jer Noble <[email protected]>
+
+ [MSE][Mac] Volume is not remembered between items in a YouTube playlist
+ https://bugs.webkit.org/show_bug.cgi?id=135479
+
+ Reviewed by Eric Carlson.
+
+ When an AVSampleBufferAudioRenderer is added to the player, set its -volume and -muted
+ properties with the current values from the HTMLMediaElement.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer):
+
2014-08-01 Tim Horton <[email protected]>
Fix the iOS build after r171891
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (171936 => 171937)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2014-08-01 18:50:05 UTC (rev 171936)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2014-08-01 18:53:38 UTC (rev 171937)
@@ -758,6 +758,10 @@
return;
m_sampleBufferAudioRenderers.append(audioRenderer);
+
+ [audioRenderer setMuted:m_player->muted()];
+ [audioRenderer setVolume:m_player->volume()];
+
[m_synchronizer addRenderer:audioRenderer];
m_player->mediaPlayerClient()->mediaPlayerRenderingModeChanged(m_player);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
