Title: [172002] trunk
- Revision
- 172002
- Author
- [email protected]
- Date
- 2014-08-04 14:17:39 -0700 (Mon, 04 Aug 2014)
Log Message
AX: Secure text fields need to support Search parameterized attributes
https://bugs.webkit.org/show_bug.cgi?id=135568
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Secure text fields still need to support the fast searching that WebKit exposes, even though they don't support
other parameterized attributes.
Test: platform/mac/accessibility/secure-text-field-supports-fast-search.html
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
LayoutTests:
* platform/mac/accessibility/secure-text-field-supports-fast-search-expected.txt: Added.
* platform/mac/accessibility/secure-text-field-supports-fast-search.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (172001 => 172002)
--- trunk/LayoutTests/ChangeLog 2014-08-04 21:13:58 UTC (rev 172001)
+++ trunk/LayoutTests/ChangeLog 2014-08-04 21:17:39 UTC (rev 172002)
@@ -1,5 +1,15 @@
2014-08-04 Chris Fleizach <[email protected]>
+ AX: Secure text fields need to support Search parameterized attributes
+ https://bugs.webkit.org/show_bug.cgi?id=135568
+
+ Reviewed by Mario Sanchez Prada.
+
+ * platform/mac/accessibility/secure-text-field-supports-fast-search-expected.txt: Added.
+ * platform/mac/accessibility/secure-text-field-supports-fast-search.html: Added.
+
+2014-08-04 Chris Fleizach <[email protected]>
+
AX: SelectText functionality always selects text after current selection even if closer selection is behind it
https://bugs.webkit.org/show_bug.cgi?id=135546
Added: trunk/LayoutTests/platform/mac/accessibility/secure-text-field-supports-fast-search-expected.txt (0 => 172002)
--- trunk/LayoutTests/platform/mac/accessibility/secure-text-field-supports-fast-search-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/secure-text-field-supports-fast-search-expected.txt 2014-08-04 21:17:39 UTC (rev 172002)
@@ -0,0 +1,11 @@
+
+This tests that secure text fields still expose the parameterized attributes for fast searching.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS passwordField.parameterizedAttributeNames().trim() is 'AXUIElementsForSearchPredicate'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/mac/accessibility/secure-text-field-supports-fast-search.html (0 => 172002)
--- trunk/LayoutTests/platform/mac/accessibility/secure-text-field-supports-fast-search.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/secure-text-field-supports-fast-search.html 2014-08-04 21:17:39 UTC (rev 172002)
@@ -0,0 +1,25 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src=""
+</head>
+<body id="body">
+
+<input type="password" id="password">
+
+<div id="console"></div>
+
+<script>
+
+ description("This tests that secure text fields still expose the parameterized attributes for fast searching.");
+
+ if (window.accessibilityController) {
+ var passwordField = accessibilityController.accessibleElementById("password");
+ shouldBe("passwordField.parameterizedAttributeNames().trim()", "'AXUIElementsForSearchPredicate'");
+ }
+
+</script>
+
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (172001 => 172002)
--- trunk/Source/WebCore/ChangeLog 2014-08-04 21:13:58 UTC (rev 172001)
+++ trunk/Source/WebCore/ChangeLog 2014-08-04 21:17:39 UTC (rev 172002)
@@ -1,3 +1,18 @@
+2014-08-04 Chris Fleizach <[email protected]>
+
+ AX: Secure text fields need to support Search parameterized attributes
+ https://bugs.webkit.org/show_bug.cgi?id=135568
+
+ Reviewed by Mario Sanchez Prada.
+
+ Secure text fields still need to support the fast searching that WebKit exposes, even though they don't support
+ other parameterized attributes.
+
+ Test: platform/mac/accessibility/secure-text-field-supports-fast-search.html
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
+
2014-08-04 Jer Noble <[email protected]>
[MSE] Further fixes for "fast forward" playback after seeking in YouTube behavior.
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (172001 => 172002)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-08-04 21:13:58 UTC (rev 172001)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-08-04 21:17:39 UTC (rev 172002)
@@ -3119,7 +3119,7 @@
}
if (m_object->isPasswordField())
- return [NSArray array];
+ return @[ NSAccessibilityUIElementsForSearchPredicateParameterizedAttribute ];
if (!m_object->isAccessibilityRenderObject())
return paramAttrs;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
