Title: [172053] trunk/Source/WebCore
Revision
172053
Author
an...@apple.com
Date
2014-08-05 13:15:40 -0700 (Tue, 05 Aug 2014)

Log Message

REGRESSION: Extremely flashy scrolling while a page is still loading (because of flush throttling)
https://bugs.webkit.org/show_bug.cgi?id=135603
<rdar://problem/17876385>
        
This hit ASSERT(frame().isMainFrame()) in FrameView::updateLayerFlushThrottling
running scrollbars/scrollbar-iframe-click-does-not-blur-content.html and a few other tests.

* page/FrameView.cpp:
(WebCore::FrameView::setWasScrolledByUser): Only invoke updateLayerFlushThrottling for the main frame.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (172052 => 172053)


--- trunk/Source/WebCore/ChangeLog	2014-08-05 20:07:32 UTC (rev 172052)
+++ trunk/Source/WebCore/ChangeLog	2014-08-05 20:15:40 UTC (rev 172053)
@@ -1,3 +1,15 @@
+2014-08-05  Antti Koivisto  <an...@apple.com>
+
+        REGRESSION: Extremely flashy scrolling while a page is still loading (because of flush throttling)
+        https://bugs.webkit.org/show_bug.cgi?id=135603
+        <rdar://problem/17876385>
+        
+        This hit ASSERT(frame().isMainFrame()) in FrameView::updateLayerFlushThrottling
+        running scrollbars/scrollbar-iframe-click-does-not-blur-content.html and a few other tests.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::setWasScrolledByUser): Only invoke updateLayerFlushThrottling for the main frame.
+
 2014-08-05  Peyton Randolph  <prando...@apple.com>
 
         Rename MAC_LONG_PRESS feature flag to LONG_MOUSE_PRESS.

Modified: trunk/Source/WebCore/page/FrameView.cpp (172052 => 172053)


--- trunk/Source/WebCore/page/FrameView.cpp	2014-08-05 20:07:32 UTC (rev 172052)
+++ trunk/Source/WebCore/page/FrameView.cpp	2014-08-05 20:15:40 UTC (rev 172053)
@@ -3569,7 +3569,8 @@
     if (m_wasScrolledByUser == wasScrolledByUser)
         return;
     m_wasScrolledByUser = wasScrolledByUser;
-    updateLayerFlushThrottling();
+    if (frame().isMainFrame())
+        updateLayerFlushThrottling();
     adjustTiledBackingCoverage();
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to