Title: [172083] trunk/Source/WebCore
- Revision
- 172083
- Author
- d...@apple.com
- Date
- 2014-08-05 14:33:54 -0700 (Tue, 05 Aug 2014)
Log Message
[iOS] Media controls layout incorrectly in RTL content
https://bugs.webkit.org/show_bug.cgi?id=135621
<rdar://problem/17849206>
Reviewed by Eric Carlson.
Media controls should always layout in LTR mode, even when the
page content is RTL. There already was a rule to do this on
non-iOS systems, but it wasn't getting included for iOS.
In this case I put the rule on the composited parent of the
controls in order to maintain the padding of the control panel.
This should still leave the captions unaffected.
* Modules/mediacontrols/mediaControlsiOS.css:
(video::-webkit-media-controls-panel-composited-parent): Add direction: ltr.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (172082 => 172083)
--- trunk/Source/WebCore/ChangeLog 2014-08-05 21:33:24 UTC (rev 172082)
+++ trunk/Source/WebCore/ChangeLog 2014-08-05 21:33:54 UTC (rev 172083)
@@ -1,3 +1,21 @@
+2014-08-05 Dean Jackson <d...@apple.com>
+
+ [iOS] Media controls layout incorrectly in RTL content
+ https://bugs.webkit.org/show_bug.cgi?id=135621
+ <rdar://problem/17849206>
+
+ Reviewed by Eric Carlson.
+
+ Media controls should always layout in LTR mode, even when the
+ page content is RTL. There already was a rule to do this on
+ non-iOS systems, but it wasn't getting included for iOS.
+ In this case I put the rule on the composited parent of the
+ controls in order to maintain the padding of the control panel.
+ This should still leave the captions unaffected.
+
+ * Modules/mediacontrols/mediaControlsiOS.css:
+ (video::-webkit-media-controls-panel-composited-parent): Add direction: ltr.
+
2014-08-05 Brian J. Burg <b...@cs.washington.edu>
Web Replay: rename protocol methods for getting replay session/segment data
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css (172082 => 172083)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2014-08-05 21:33:24 UTC (rev 172082)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2014-08-05 21:33:54 UTC (rev 172083)
@@ -117,6 +117,7 @@
video::-webkit-media-controls-panel-composited-parent {
-webkit-transform: translateZ(0);
width: 100%;
+ direction: ltr;
}
audio::-webkit-media-controls-panel,
@@ -144,7 +145,6 @@
background-color: rgba(228, 228, 228, 1);
}
-
audio::-webkit-media-controls-panel {
height: 39px;
padding-right: 8px;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
