Title: [172592] trunk/Source/WebKit2
Revision
172592
Author
commit-qu...@webkit.org
Date
2014-08-14 10:52:35 -0700 (Thu, 14 Aug 2014)

Log Message

WebKit2GTK - WebKitWebProcess assertion fails when dragging and dropping a file into the view
https://bugs.webkit.org/show_bug.cgi?id=127576

Patch by Michael Catanzaro <mcatanz...@igalia.com> on 2014-08-14
Reviewed by Carlos Garcia Campos.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performDragControllerAction): Assume read access
to any file that has been dragged into the web view when compiling for
GTK, since we don't support sandbox extensions.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (172591 => 172592)


--- trunk/Source/WebKit2/ChangeLog	2014-08-14 17:49:55 UTC (rev 172591)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-14 17:52:35 UTC (rev 172592)
@@ -1,3 +1,15 @@
+2014-08-14  Michael Catanzaro  <mcatanz...@igalia.com>
+
+        WebKit2GTK - WebKitWebProcess assertion fails when dragging and dropping a file into the view
+        https://bugs.webkit.org/show_bug.cgi?id=127576
+
+        Reviewed by Carlos Garcia Campos.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::performDragControllerAction): Assume read access
+        to any file that has been dragged into the web view when compiling for
+        GTK, since we don't support sandbox extensions.
+
 2014-08-13  Wenson Hsieh  <wenson_hs...@apple.com>
 
         Enable CSS_SCROLL_SNAP for iOS

Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (172591 => 172592)


--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-08-14 17:49:55 UTC (rev 172591)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-08-14 17:52:35 UTC (rev 172592)
@@ -1361,6 +1361,10 @@
     UNUSED_PARAM(dragStorageName);
     UNUSED_PARAM(sandboxExtensionHandle);
     UNUSED_PARAM(sandboxExtensionsForUpload);
+
+    String url = ""
+    if (!url.isEmpty())
+        m_process->assumeReadAccessToBaseURL(url);
     m_process->send(Messages::WebPage::PerformDragControllerAction(action, dragData), m_pageID);
 #else
     m_process->send(Messages::WebPage::PerformDragControllerAction(action, dragData.clientPosition(), dragData.globalPosition(), dragData.draggingSourceOperationMask(), dragStorageName, dragData.flags(), sandboxExtensionHandle, sandboxExtensionsForUpload), m_pageID);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to