Title: [172653] trunk/Source/WebKit2
- Revision
- 172653
- Author
- [email protected]
- Date
- 2014-08-15 14:22:13 -0700 (Fri, 15 Aug 2014)
Log Message
Fix plugin visibility check.
https://bugs.webkit.org/show_bug.cgi?id=135991
D'oh, more unreviewed typo fix. :-(
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::visibilityDidChange):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
(WebKit::PluginControllerProxy::updateVisibilityActivity):
(WebKit::PluginControllerProxy::updateVisiblityActivity): Deleted.
* PluginProcess/PluginControllerProxy.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (172652 => 172653)
--- trunk/Source/WebKit2/ChangeLog 2014-08-15 21:16:21 UTC (rev 172652)
+++ trunk/Source/WebKit2/ChangeLog 2014-08-15 21:22:13 UTC (rev 172653)
@@ -1,3 +1,17 @@
+2014-08-15 Gavin Barraclough <[email protected]>
+
+ Fix plugin visibility check.
+ https://bugs.webkit.org/show_bug.cgi?id=135991
+
+ D'oh, more unreviewed typo fix. :-(
+
+ * PluginProcess/PluginControllerProxy.cpp:
+ (WebKit::PluginControllerProxy::visibilityDidChange):
+ (WebKit::PluginControllerProxy::windowVisibilityChanged):
+ (WebKit::PluginControllerProxy::updateVisibilityActivity):
+ (WebKit::PluginControllerProxy::updateVisiblityActivity): Deleted.
+ * PluginProcess/PluginControllerProxy.h:
+
2014-08-15 Wenson Hsieh <[email protected]>
Implement snapping behavior for iOS
@@ -33,7 +47,7 @@
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::visibilityDidChange):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
- (WebKit::PluginControllerProxy::updateVisiblityActivity):
+ (WebKit::PluginControllerProxy::updateVisibilityActivity):
* PluginProcess/PluginControllerProxy.h:
2014-08-15 Gavin Barraclough <[email protected]>
@@ -51,8 +65,8 @@
- initialize member state.
(WebKit::PluginControllerProxy::visibilityDidChange):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
- - update member state & call updateVisiblityActivity.
- (WebKit::PluginControllerProxy::updateVisiblityActivity):
+ - update member state & call updateVisibilityActivity.
+ (WebKit::PluginControllerProxy::updateVisibilityActivity):
- enable the UserActivity only if both visibilities are true.
* PluginProcess/PluginControllerProxy.h:
- added m_isVisible, m_isWindowVisible, updateVisibilityActivity.
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (172652 => 172653)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2014-08-15 21:16:21 UTC (rev 172652)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2014-08-15 21:22:13 UTC (rev 172653)
@@ -437,7 +437,7 @@
ASSERT(m_plugin);
m_plugin->visibilityDidChange(isVisible);
- updateVisiblityActivity();
+ updateVisibilityActivity();
}
void PluginControllerProxy::windowFocusChanged(bool hasFocus)
@@ -453,10 +453,10 @@
ASSERT(m_plugin);
m_plugin->windowVisibilityChanged(isVisible);
- updateVisiblityActivity();
+ updateVisibilityActivity();
}
-void PluginControllerProxy::updateVisiblityActivity()
+void PluginControllerProxy::updateVisibilityActivity()
{
if (m_isVisible && m_isWindowVisible)
m_visiblityActivity.start();
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h (172652 => 172653)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h 2014-08-15 21:16:21 UTC (rev 172652)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h 2014-08-15 21:22:13 UTC (rev 172653)
@@ -151,7 +151,7 @@
void windowFocusChanged(bool);
void windowVisibilityChanged(bool);
- void updateVisiblityActivity();
+ void updateVisibilityActivity();
#if PLATFORM(COCOA)
void windowAndViewFramesChanged(const WebCore::IntRect& windowFrameInScreenCoordinates, const WebCore::IntRect& viewFrameInWindowCoordinates);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
