Title: [172968] trunk/Source/WebKit2
Revision
172968
Author
simon.fra...@apple.com
Date
2014-08-26 11:55:16 -0700 (Tue, 26 Aug 2014)

Log Message

Crashes in hit testing under WebPage::determinePrimarySnapshottedPlugIn()
https://bugs.webkit.org/show_bug.cgi?id=136240
rdar://problem/17231462

Reviewed by Darin Adler.

determinePrimarySnapshottedPlugIn() does render tree hit testing, so needs
to ensure that layout is up-to-date.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (172967 => 172968)


--- trunk/Source/WebKit2/ChangeLog	2014-08-26 18:44:46 UTC (rev 172967)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-26 18:55:16 UTC (rev 172968)
@@ -1,3 +1,17 @@
+2014-08-26  Simon Fraser  <simon.fra...@apple.com>
+
+        Crashes in hit testing under WebPage::determinePrimarySnapshottedPlugIn()
+        https://bugs.webkit.org/show_bug.cgi?id=136240
+        rdar://problem/17231462
+
+        Reviewed by Darin Adler.
+        
+        determinePrimarySnapshottedPlugIn() does render tree hit testing, so needs
+        to ensure that layout is up-to-date.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::determinePrimarySnapshottedPlugIn):
+
 2014-08-26  Tim Horton  <timothy_hor...@apple.com>
 
         REGRESSION (r172771): Amazon product page becomes unresponsive after swiping back to it

Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (172967 => 172968)


--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2014-08-26 18:44:46 UTC (rev 172967)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2014-08-26 18:55:16 UTC (rev 172968)
@@ -4553,6 +4553,8 @@
 
     ++m_numberOfPrimarySnapshotDetectionAttempts;
 
+    layoutIfNeeded();
+
     MainFrame& mainFrame = corePage()->mainFrame();
     if (!mainFrame.view())
         return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to