Title: [172974] trunk/Source/WebKit2
- Revision
- 172974
- Author
- dburk...@apple.com
- Date
- 2014-08-26 13:37:04 -0700 (Tue, 26 Aug 2014)
Log Message
The UNUSED_PARAM macros in ServicesOverlayController.mm are causing ASan build failures.
https://bugs.webkit.org/show_bug.cgi?id=136262
Reviewed by David Kilzer.
* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::selectionRectsDidChange):
(WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (172973 => 172974)
--- trunk/Source/WebKit2/ChangeLog 2014-08-26 20:12:57 UTC (rev 172973)
+++ trunk/Source/WebKit2/ChangeLog 2014-08-26 20:37:04 UTC (rev 172974)
@@ -1,3 +1,14 @@
+2014-08-26 Dana Burkart <dburk...@apple.com>
+
+ The UNUSED_PARAM macros in ServicesOverlayController.mm are causing ASan build failures.
+ https://bugs.webkit.org/show_bug.cgi?id=136262
+
+ Reviewed by David Kilzer.
+
+ * WebProcess/WebPage/mac/ServicesOverlayController.mm:
+ (WebKit::ServicesOverlayController::selectionRectsDidChange):
+ (WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
+
2014-08-26 Csaba Osztrogonác <o...@webkit.org>
[EFL] URTBF after r172966.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm (172973 => 172974)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm 2014-08-26 20:12:57 UTC (rev 172973)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm 2014-08-26 20:37:04 UTC (rev 172974)
@@ -376,7 +376,7 @@
void ServicesOverlayController::selectionRectsDidChange(const Vector<LayoutRect>& rects, const Vector<GapRects>& gapRects, bool isTextOnly)
{
-#if __MAC_OS_X_VERSION_MIN_REQUIRED > 1090
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 1090
m_currentSelectionRects = rects;
m_isTextOnly = isTextOnly;
@@ -392,6 +392,8 @@
buildSelectionHighlight();
#else
UNUSED_PARAM(rects);
+ UNUSED_PARAM(gapRects);
+ UNUSED_PARAM(isTextOnly);
#endif
}
@@ -400,8 +402,6 @@
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 1090
LOG(Services, "ServicesOverlayController - Telephone number ranges changed\n");
buildPhoneNumberHighlights();
-#else
- UNUSED_PARAM(ranges);
#endif
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
