Title: [172996] trunk/Tools
Revision
172996
Author
[email protected]
Date
2014-08-26 23:43:57 -0700 (Tue, 26 Aug 2014)

Log Message

build.webkit.org/dashboard raises an exception after a hidden platform is removed
https://bugs.webkit.org/show_bug.cgi?id=136282

Reviewed by Tim Horton.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(updateHiddenPlatforms): Check that the platform is still valid.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js (172995 => 172996)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js	2014-08-27 03:53:00 UTC (rev 172995)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js	2014-08-27 06:43:57 UTC (rev 172996)
@@ -109,8 +109,11 @@
     for (var i = 0; i < platformRows.length; ++i)
         platformRows[i].classList.remove("hidden");
 
-    for (var i = 0; i < hiddenPlatforms.length; ++i)
-        document.querySelector("tr.platform." + hiddenPlatforms[i]).classList.add("hidden");
+    for (var i = 0; i < hiddenPlatforms.length; ++i) {
+        var platformRow = document.querySelector("tr.platform." + hiddenPlatforms[i]);
+        if (platformRow)
+            platformRow.classList.add("hidden");
+    }
 
     var unhideButton = document.querySelector("div.cellButton.unhide");
     if (hiddenPlatforms.length)

Modified: trunk/Tools/ChangeLog (172995 => 172996)


--- trunk/Tools/ChangeLog	2014-08-27 03:53:00 UTC (rev 172995)
+++ trunk/Tools/ChangeLog	2014-08-27 06:43:57 UTC (rev 172996)
@@ -1,3 +1,13 @@
+2014-08-26  Alexey Proskuryakov  <[email protected]>
+
+        build.webkit.org/dashboard raises an exception after a hidden platform is removed
+        https://bugs.webkit.org/show_bug.cgi?id=136282
+
+        Reviewed by Tim Horton.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
+        (updateHiddenPlatforms): Check that the platform is still valid.
+
 2014-08-26  Matt Lilek  <[email protected]>
 
         Add WebKit SPI to control the navigator.standalone property
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to