Title: [173015] trunk/Source/WebInspectorUI
- Revision
- 173015
- Author
- [email protected]
- Date
- 2014-08-27 13:19:33 -0700 (Wed, 27 Aug 2014)
Log Message
Web Inspector: Layout issues for popover on not legacy OS
https://bugs.webkit.org/show_bug.cgi?id=136268
Patch by Saam Barati <[email protected]> on 2014-08-27
Reviewed by Joseph Pecoraro.
On the latest OS, popovers invade the title bar's space which will
cause layout issues because the title bar will render above
the popover. Fix this by providing some padding for popovers on
not legacy OSs.
* UserInterface/Views/Popover.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (173014 => 173015)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-08-27 19:53:31 UTC (rev 173014)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-08-27 20:19:33 UTC (rev 173015)
@@ -1,3 +1,17 @@
+2014-08-27 Saam Barati <[email protected]>
+
+ Web Inspector: Layout issues for popover on not legacy OS
+ https://bugs.webkit.org/show_bug.cgi?id=136268
+
+ Reviewed by Joseph Pecoraro.
+
+ On the latest OS, popovers invade the title bar's space which will
+ cause layout issues because the title bar will render above
+ the popover. Fix this by providing some padding for popovers on
+ not legacy OSs.
+
+ * UserInterface/Views/Popover.js:
+
2014-08-27 Timothy Hatcher <[email protected]>
REGRESSION: Web Inspector: Legacy toolbar has two different colors in unfocused windowed mode
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js (173014 => 173015)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js 2014-08-27 19:53:31 UTC (rev 173014)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js 2014-08-27 20:19:33 UTC (rev 173015)
@@ -196,8 +196,9 @@
this._preferredSize = new WebInspector.Size(Math.ceil(popoverBounds.width), Math.ceil(popoverBounds.height));
}
+ const titleBarOffset = WebInspector.Platform.name === "mac" && !WebInspector.Platform.isLegacyMacOS ? 22 : 0;
+ var containerFrame = new WebInspector.Rect(0, titleBarOffset, window.innerWidth, window.innerHeight - titleBarOffset);
// The frame of the window with a little inset to make sure we have room for shadows.
- var containerFrame = new WebInspector.Rect(0, 0, window.innerWidth, window.innerHeight);
containerFrame = containerFrame.inset(WebInspector.Popover.ShadowEdgeInsets);
// Work out the metrics for all edges.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
