Title: [173086] branches/safari-600.1-branch/Source/WebInspectorUI
- Revision
- 173086
- Author
- lforsch...@apple.com
- Date
- 2014-08-28 15:02:25 -0700 (Thu, 28 Aug 2014)
Log Message
Merged r173015. rdar://problem/18141133
Modified Paths
Diff
Modified: branches/safari-600.1-branch/Source/WebInspectorUI/ChangeLog (173085 => 173086)
--- branches/safari-600.1-branch/Source/WebInspectorUI/ChangeLog 2014-08-28 21:59:26 UTC (rev 173085)
+++ branches/safari-600.1-branch/Source/WebInspectorUI/ChangeLog 2014-08-28 22:02:25 UTC (rev 173086)
@@ -1,5 +1,23 @@
2014-08-28 Lucas Forschler <lforsch...@apple.com>
+ Merge r173015
+
+ 2014-08-27 Saam Barati <sbar...@apple.com>
+
+ Web Inspector: Layout issues for popover on not legacy OS
+ https://bugs.webkit.org/show_bug.cgi?id=136268
+
+ Reviewed by Joseph Pecoraro.
+
+ On the latest OS, popovers invade the title bar's space which will
+ cause layout issues because the title bar will render above
+ the popover. Fix this by providing some padding for popovers on
+ not legacy OSs.
+
+ * UserInterface/Views/Popover.js:
+
+2014-08-28 Lucas Forschler <lforsch...@apple.com>
+
Merge r173010
2014-08-27 Timothy Hatcher <timo...@apple.com>
Modified: branches/safari-600.1-branch/Source/WebInspectorUI/UserInterface/Views/Popover.js (173085 => 173086)
--- branches/safari-600.1-branch/Source/WebInspectorUI/UserInterface/Views/Popover.js 2014-08-28 21:59:26 UTC (rev 173085)
+++ branches/safari-600.1-branch/Source/WebInspectorUI/UserInterface/Views/Popover.js 2014-08-28 22:02:25 UTC (rev 173086)
@@ -196,8 +196,9 @@
this._preferredSize = new WebInspector.Size(Math.ceil(popoverBounds.width), Math.ceil(popoverBounds.height));
}
+ const titleBarOffset = WebInspector.Platform.name === "mac" && !WebInspector.Platform.isLegacyMacOS ? 22 : 0;
+ var containerFrame = new WebInspector.Rect(0, titleBarOffset, window.innerWidth, window.innerHeight - titleBarOffset);
// The frame of the window with a little inset to make sure we have room for shadows.
- var containerFrame = new WebInspector.Rect(0, 0, window.innerWidth, window.innerHeight);
containerFrame = containerFrame.inset(WebInspector.Popover.ShadowEdgeInsets);
// Work out the metrics for all edges.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
