Title: [173116] trunk/Tools
Revision
173116
Author
clo...@igalia.com
Date
2014-08-29 11:15:19 -0700 (Fri, 29 Aug 2014)

Log Message

[JSC] Some JSC tests are dependent on the machine time zone.
https://bugs.webkit.org/show_bug.cgi?id=136363

Reviewed by Filip Pizlo.

* Scripts/run-_javascript_core-tests: Export TZ environment variable to US/Pacific.
Unskip the tests that were skipped on r99580.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (173115 => 173116)


--- trunk/Tools/ChangeLog	2014-08-29 18:15:04 UTC (rev 173115)
+++ trunk/Tools/ChangeLog	2014-08-29 18:15:19 UTC (rev 173116)
@@ -1,3 +1,13 @@
+2014-08-29  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        [JSC] Some JSC tests are dependent on the machine time zone.
+        https://bugs.webkit.org/show_bug.cgi?id=136363
+
+        Reviewed by Filip Pizlo.
+
+        * Scripts/run-_javascript_core-tests: Export TZ environment variable to US/Pacific.
+        Unskip the tests that were skipped on r99580.
+
 2014-08-29  Eva Balazsfalvi  <evab.u-sze...@partner.samsung.com>
 
         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169

Modified: trunk/Tools/Scripts/run-_javascript_core-tests (173115 => 173116)


--- trunk/Tools/Scripts/run-_javascript_core-tests	2014-08-29 18:15:04 UTC (rev 173115)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2014-08-29 18:15:19 UTC (rev 173116)
@@ -54,11 +54,6 @@
     # ecma_3/Date/15.9.5.7.js fails on Mac (but not Windows) https://bugs.webkit.org/show_bug.cgi?id=25161
     "ecma_3/Date/15.9.5.6.js",
     "ecma_3/Date/15.9.5.7.js",
-    # These three fail on Linux in certain time zones, at certain times
-    # of the year (!): https://bugs.webkit.org/show_bug.cgi?id=71371
-    "ecma/Date/15.9.5.14.js",
-    "ecma/Date/15.9.5.31-1.js",
-    "ecma/Date/15.9.5.34-1.js",
 );
 
 my $jsDriverArgs = "-L " . join(" ", @testsToSkip);
@@ -149,6 +144,7 @@
 my $productDir = jscProductDir();
 $ENV{DYLD_FRAMEWORK_PATH} = $productDir;
 $ENV{JSC_timeout} = 60 unless $ENV{JSC_timeout}; # Set a 60 second timeout on all jsc tests (if environment variable not defined already).
+$ENV{TZ}="US/Pacific"; # Some tests fail if the time zone is not set to US/Pacific (<https://webkit.org/b/136363>)
 setPathForRunningWebKitApp(\%ENV) if isCygwin();
 
 sub testapiPath($)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to