Title: [173439] trunk/Source/WebCore
- Revision
- 173439
- Author
- [email protected]
- Date
- 2014-09-09 13:30:23 -0700 (Tue, 09 Sep 2014)
Log Message
[MSE] media/media-source tests broken after r173318
https://bugs.webkit.org/show_bug.cgi?id=136675
Reviewed by Eric Carlson.
Fixes the following tests:
http/tests/media/media-source/mediasource-play.html
http/tests/media/media-source/mediasource-remove.html
media/media-source/media-source-monitor-source-buffers.html
media/media-source/media-source-overlapping-append-buffered.html
In r173318, a for loop was converted to a C++11 loop, but in so doing, left
pre-initialized, empty values in the beginning of returned Vector, which caused
the calling algorithm to miscalculate the amount of data buffered by the media
source.
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::activeRanges):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (173438 => 173439)
--- trunk/Source/WebCore/ChangeLog 2014-09-09 20:12:56 UTC (rev 173438)
+++ trunk/Source/WebCore/ChangeLog 2014-09-09 20:30:23 UTC (rev 173439)
@@ -1,3 +1,24 @@
+2014-09-09 Jer Noble <[email protected]>
+
+ [MSE] media/media-source tests broken after r173318
+ https://bugs.webkit.org/show_bug.cgi?id=136675
+
+ Reviewed by Eric Carlson.
+
+ Fixes the following tests:
+ http/tests/media/media-source/mediasource-play.html
+ http/tests/media/media-source/mediasource-remove.html
+ media/media-source/media-source-monitor-source-buffers.html
+ media/media-source/media-source-overlapping-append-buffered.html
+
+ In r173318, a for loop was converted to a C++11 loop, but in so doing, left
+ pre-initialized, empty values in the beginning of returned Vector, which caused
+ the calling algorithm to miscalculate the amount of data buffered by the media
+ source.
+
+ * Modules/mediasource/MediaSource.cpp:
+ (WebCore::MediaSource::activeRanges):
+
2014-09-09 Takeshi Kurosawa <[email protected]>
AX: HTML5 landmark (and related) elements should not be ignored.
Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp (173438 => 173439)
--- trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2014-09-09 20:12:56 UTC (rev 173438)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2014-09-09 20:30:23 UTC (rev 173439)
@@ -814,7 +814,7 @@
Vector<PlatformTimeRanges> MediaSource::activeRanges() const
{
- Vector<PlatformTimeRanges> activeRanges(m_activeSourceBuffers->length());
+ Vector<PlatformTimeRanges> activeRanges;
for (auto& sourceBuffer : *m_activeSourceBuffers)
activeRanges.append(sourceBuffer->buffered()->ranges());
return activeRanges;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
