Title: [173789] trunk/Tools
- Revision
- 173789
- Author
- [email protected]
- Date
- 2014-09-19 22:46:09 -0700 (Fri, 19 Sep 2014)
Log Message
JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
https://bugs.webkit.org/show_bug.cgi?id=136974
Patch by Joseph Pecoraro <[email protected]> on 2014-09-19
Reviewed by Chris Fleizach.
* DumpRenderTree/AccessibilityUIElement.cpp:
(selectTextWithCriteriaCallback):
Be sure to release the string if it was allocated.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (173788 => 173789)
--- trunk/Tools/ChangeLog 2014-09-20 03:07:59 UTC (rev 173788)
+++ trunk/Tools/ChangeLog 2014-09-20 05:46:09 UTC (rev 173789)
@@ -1,3 +1,14 @@
+2014-09-19 Joseph Pecoraro <[email protected]>
+
+ JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
+ https://bugs.webkit.org/show_bug.cgi?id=136974
+
+ Reviewed by Chris Fleizach.
+
+ * DumpRenderTree/AccessibilityUIElement.cpp:
+ (selectTextWithCriteriaCallback):
+ Be sure to release the string if it was allocated.
+
2014-09-19 Alexey Proskuryakov <[email protected]>
build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
Modified: trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp (173788 => 173789)
--- trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp 2014-09-20 03:07:59 UTC (rev 173788)
+++ trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp 2014-09-20 05:46:09 UTC (rev 173789)
@@ -275,6 +275,8 @@
JSRetainPtr<JSStringRef> result(Adopt, toAXElement(thisObject)->selectTextWithCriteria(context, ambiguityResolution.get(), searchStrings, replacementString, activityString));
if (replacementString)
JSStringRelease(replacementString);
+ if (activityString)
+ JSStringRelease(activityString);
return JSValueMakeString(context, result.get());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
