Title: [173903] trunk/Tools
- Revision
- 173903
- Author
- roger_f...@apple.com
- Date
- 2014-09-23 17:46:22 -0700 (Tue, 23 Sep 2014)
Log Message
[Windows] More debugging for the Windows bots.
* Scripts/webkitpy/common/system/path.py:
(_CygPath):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (173902 => 173903)
--- trunk/Tools/ChangeLog 2014-09-24 00:16:25 UTC (rev 173902)
+++ trunk/Tools/ChangeLog 2014-09-24 00:46:22 UTC (rev 173903)
@@ -1,5 +1,12 @@
2014-09-23 Roger Fong <roger_f...@apple.com>
+ [Windows] More debugging for the Windows bots.
+
+ * Scripts/webkitpy/common/system/path.py:
+ (_CygPath):
+
+2014-09-23 Roger Fong <roger_f...@apple.com>
+
Unreviewed. Fix for r173899, those tabs should be spaces.
* Scripts/webkitpy/port/driver.py:
Modified: trunk/Tools/Scripts/webkitpy/common/system/path.py (173902 => 173903)
--- trunk/Tools/Scripts/webkitpy/common/system/path.py 2014-09-24 00:16:25 UTC (rev 173902)
+++ trunk/Tools/Scripts/webkitpy/common/system/path.py 2014-09-24 00:46:22 UTC (rev 173903)
@@ -31,9 +31,11 @@
import atexit
import subprocess
import sys
+import logging
import threading
import urllib
+_log = logging.getLogger(__name__)
def abspath_to_uri(platform, path):
"""Converts a platform-specific absolute path to a file: URL."""
@@ -98,9 +100,11 @@
def convert(self, path):
if not self.is_running():
self.start()
+ _log.error("Input to convert: %s" % path)
self._child_process.stdin.write("%s\r\n" % path)
self._child_process.stdin.flush()
windows_path = self._child_process.stdout.readline().rstrip()
+ _log.error("Windows path: %s" % windows_path)
# Some versions of cygpath use lowercase drive letters while others
# use uppercase. We always convert to uppercase for consistency.
windows_path = '%s%s' % (windows_path[0].upper(), windows_path[1:])
Modified: trunk/Tools/Scripts/webkitpy/port/driver.py (173902 => 173903)
--- trunk/Tools/Scripts/webkitpy/port/driver.py 2014-09-24 00:16:25 UTC (rev 173902)
+++ trunk/Tools/Scripts/webkitpy/port/driver.py 2014-09-24 00:46:22 UTC (rev 173903)
@@ -392,7 +392,6 @@
else:
command = self._port.abspath_for_test(driver_input.test_name)
if sys.platform == 'cygwin':
- _log.error("Command for cygpath: %s" % command)
command = path.cygpath(command)
assert not driver_input.image_hash or driver_input.should_run_pixel_test
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
