Title: [174201] trunk/Tools
- Revision
- 174201
- Author
- commit-qu...@webkit.org
- Date
- 2014-10-01 23:19:27 -0700 (Wed, 01 Oct 2014)
Log Message
EWS and Commit Queue should know better than to spew 500 failed
results in the case of extremely red patches.
https://bugs.webkit.org/show_bug.cgi?id=137324
Patch by Jake Nielsen <jacob_niel...@apple.com> on 2014-10-01
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Adds a check for did_exceed_test_failure_limit.
(AbstractEarlyWarningSystem._failing_tests_message):
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Alters the task mock to respond properly to
results_from_patch_test_run(patch)
(AbstractEarlyWarningSystemTest.test_failing_tests_message):
* Scripts/webkitpy/tool/commands/queues.py:
Adds a check for did_exceed_test_failure_limit.
(CommitQueue._failing_tests_message):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (174200 => 174201)
--- trunk/Tools/ChangeLog 2014-10-02 06:19:00 UTC (rev 174200)
+++ trunk/Tools/ChangeLog 2014-10-02 06:19:27 UTC (rev 174201)
@@ -1,3 +1,22 @@
+2014-10-01 Jake Nielsen <jacob_niel...@apple.com>
+
+ EWS and Commit Queue should know better than to spew 500 failed
+ results in the case of extremely red patches.
+ https://bugs.webkit.org/show_bug.cgi?id=137324
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+ Adds a check for did_exceed_test_failure_limit.
+ (AbstractEarlyWarningSystem._failing_tests_message):
+ * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+ Alters the task mock to respond properly to
+ results_from_patch_test_run(patch)
+ (AbstractEarlyWarningSystemTest.test_failing_tests_message):
+ * Scripts/webkitpy/tool/commands/queues.py:
+ Adds a check for did_exceed_test_failure_limit.
+ (CommitQueue._failing_tests_message):
+
2014-10-01 Daniel Bates <daba...@apple.com>
Unreviewed, rolling out r174192.
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py (174200 => 174201)
--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2014-10-02 06:19:00 UTC (rev 174200)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2014-10-02 06:19:27 UTC (rev 174201)
@@ -63,6 +63,8 @@
unexpected_failures = self._expected_failures.unexpected_failures_observed(results)
if not unexpected_failures:
return None
+ if results and results.did_exceed_test_failure_limit():
+ return "Number of test failures exceeded the failure limit."
return "New failing tests:\n%s" % "\n".join(unexpected_failures)
def _post_reject_message_on_bug(self, tool, patch, status_id, extra_message_text=None):
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (174200 => 174201)
--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2014-10-02 06:19:00 UTC (rev 174200)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2014-10-02 06:19:27 UTC (rev 174201)
@@ -46,6 +46,7 @@
OutputCapture().assert_outputs(self, ews.begin_work_queue, expected_logs=self._default_begin_work_queue_logs(ews.name))
ews._expected_failures.unexpected_failures_observed = lambda results: set(["foo.html", "bar.html"])
task = Mock()
+ task.results_from_patch_test_run = lambda a: None
patch = ews._tool.bugs.fetch_attachment(10000)
self.assertMultiLineEqual(ews._failing_tests_message(task, patch), "New failing tests:\nbar.html\nfoo.html")
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues.py (174200 => 174201)
--- trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2014-10-02 06:19:00 UTC (rev 174200)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2014-10-02 06:19:27 UTC (rev 174201)
@@ -336,6 +336,8 @@
unexpected_failures = self._expected_failures.unexpected_failures_observed(results)
if not unexpected_failures:
return None
+ if results and results.did_exceed_test_failure_limit():
+ return "Number of test failures exceeded the failure limit."
return "New failing tests:\n%s" % "\n".join(unexpected_failures)
def _error_message_for_bug(self, task, patch, script_error):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
