Title: [174357] trunk/Tools
Revision
174357
Author
[email protected]
Date
2014-10-06 12:09:55 -0700 (Mon, 06 Oct 2014)

Log Message

webkit-queues PatchLog is incorrect for patches that took less than a second
https://bugs.webkit.org/show_bug.cgi?id=137453

Reviewed by Tim Horton.

* QueueStatusServer/app.yaml: Updated app version.

* QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
Don't bail out for patches that took 0 seconds to process (as frequently happens
when a patch is obsolete).

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (174356 => 174357)


--- trunk/Tools/ChangeLog	2014-10-06 18:57:59 UTC (rev 174356)
+++ trunk/Tools/ChangeLog	2014-10-06 19:09:55 UTC (rev 174357)
@@ -1,3 +1,16 @@
+2014-10-06  Alexey Proskuryakov  <[email protected]>
+
+        webkit-queues PatchLog is incorrect for patches that took less than a second
+        https://bugs.webkit.org/show_bug.cgi?id=137453
+
+        Reviewed by Tim Horton.
+
+        * QueueStatusServer/app.yaml: Updated app version.
+
+        * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
+        Don't bail out for patches that took 0 seconds to process (as frequently happens
+        when a patch is obsolete).
+
 2014-10-06  Csaba Osztrogonác  <[email protected]>
 
         EWS bubble hover shows wrong timestamps

Modified: trunk/Tools/QueueStatusServer/app.yaml (174356 => 174357)


--- trunk/Tools/QueueStatusServer/app.yaml	2014-10-06 18:57:59 UTC (rev 174356)
+++ trunk/Tools/QueueStatusServer/app.yaml	2014-10-06 19:09:55 UTC (rev 174357)
@@ -1,5 +1,5 @@
 application: webkit-queues
-version: 174304 # Bugzilla bug ID of last major change
+version: 174357 # SVN revision of last major change
 runtime: python
 api_version: 1
 

Modified: trunk/Tools/QueueStatusServer/loggers/recordpatchevent.py (174356 => 174357)


--- trunk/Tools/QueueStatusServer/loggers/recordpatchevent.py	2014-10-06 18:57:59 UTC (rev 174356)
+++ trunk/Tools/QueueStatusServer/loggers/recordpatchevent.py	2014-10-06 19:09:55 UTC (rev 174357)
@@ -75,7 +75,7 @@
             WarningLog.record("patchlog missing", "In stopped event.", attachment_id, queue_name, bot_id)
             return
 
-        if not patch_log.wait_duration:
+        if patch_log.wait_duration is None:
             WarningLog.record("patchlog wait duration missing", "In stopped event.", attachment_id, queue_name, bot_id)
             return
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to