Title: [174373] trunk/Source/WebCore
Revision
174373
Author
[email protected]
Date
2014-10-06 16:54:27 -0700 (Mon, 06 Oct 2014)

Log Message

Addressing post-review comment on r174297.
https://bugs.webkit.org/show_bug.cgi?id=137355

Unreviewed.

* rendering/RenderText.cpp:
(WebCore::RenderText::stringView):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (174372 => 174373)


--- trunk/Source/WebCore/ChangeLog	2014-10-06 22:44:33 UTC (rev 174372)
+++ trunk/Source/WebCore/ChangeLog	2014-10-06 23:54:27 UTC (rev 174373)
@@ -1,5 +1,15 @@
 2014-10-06  Myles C. Maxfield  <[email protected]>
 
+        Addressing post-review comment on r174297.
+        https://bugs.webkit.org/show_bug.cgi?id=137355
+
+        Unreviewed.
+
+        * rendering/RenderText.cpp:
+        (WebCore::RenderText::stringView):
+
+2014-10-06  Myles C. Maxfield  <[email protected]>
+
         Unreviewed merge fix for r174279.
         https://bugs.webkit.org/show_bug.cgi?id=137097
 

Modified: trunk/Source/WebCore/rendering/RenderText.cpp (174372 => 174373)


--- trunk/Source/WebCore/rendering/RenderText.cpp	2014-10-06 22:44:33 UTC (rev 174372)
+++ trunk/Source/WebCore/rendering/RenderText.cpp	2014-10-06 23:54:27 UTC (rev 174373)
@@ -1527,6 +1527,11 @@
 
 StringView RenderText::stringView(int start, int stop) const
 {
+    ASSERT(static_cast<unsigned>(start) <= length());
+    ASSERT(static_cast<unsigned>(stop) <= length());
+    ASSERT(start <= stop);
+    ASSERT(start >= 0);
+    ASSERT(stop >= 0);
     if (is8Bit())
         return StringView(characters8() + start, stop - start);
     return StringView(characters16() + start, stop - start);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to