[webkit-changes] [174418] trunk/Tools

[commit-queue]

Title: [174418] trunk/Tools

Revision

174418

Author

commit-qu...@webkit.org

Date

2014-10-07 22:36:24 -0700 (Tue, 07 Oct 2014)

Log Message

Remove build warnings in Hashmap API tests
https://bugs.webkit.org/show_bug.cgi?id=137484

Patch by Tanay C <tana...@samsung.com> on 2014-10-07
Reviewed by Darin Adler.

* TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry)

Modified Paths

• trunk/Tools/ChangeLog
• trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp

Diff

Modified: trunk/Tools/ChangeLog (174417 => 174418)

--- trunk/Tools/ChangeLog	2014-10-08 05:17:29 UTC (rev 174417)
+++ trunk/Tools/ChangeLog	2014-10-08 05:36:24 UTC (rev 174418)
@@ -1,3 +1,13 @@
+2014-10-07  Tanay C  <tana...@samsung.com>
+
+        Remove build warnings in Hashmap API tests
+        https://bugs.webkit.org/show_bug.cgi?id=137484
+
+        Reviewed by Darin Adler.
+
+        * TestWebKitAPI/Tests/WTF/HashMap.cpp:
+        (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
+
 2014-10-07  Jake Nielsen  <jacob_niel...@apple.com>
 
         Commit queue doesn't drop obsolete patches sometimes

Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp (174417 => 174418)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp	2014-10-08 05:17:29 UTC (rev 174417)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp	2014-10-08 05:36:24 UTC (rev 174418)
@@ -447,7 +447,7 @@
     {
         RefPtr<RefLogger> ptr2(&a);
         auto addResult = map.add(ptr2, 0);
-        EXPECT_EQ(false, addResult.isNewEntry);
+        EXPECT_FALSE(addResult.isNewEntry);
     }
 
     EXPECT_STREQ("ref(a) deref(a) ", takeLogStr().c_str());
@@ -469,7 +469,7 @@
     {
         RefPtr<RefLogger> ptr2(&a);
         auto addResult = map.add(ptr2.release(), 0);
-        EXPECT_EQ(false, addResult.isNewEntry);
+        EXPECT_FALSE(addResult.isNewEntry);
     }
 
     EXPECT_STREQ("ref(a) deref(a) ", takeLogStr().c_str());
@@ -491,7 +491,7 @@
     {
         RefPtr<RefLogger> ptr2(&a);
         auto addResult = map.add(WTF::move(ptr2), 0);
-        EXPECT_EQ(false, addResult.isNewEntry);
+        EXPECT_FALSE(addResult.isNewEntry);
     }
 
     EXPECT_STREQ("ref(a) deref(a) ", takeLogStr().c_str());
@@ -556,7 +556,7 @@
     {
         RefPtr<RefLogger> ptr2(&a);
         auto addResult = map.set(ptr2, 1);
-        EXPECT_EQ(false, addResult.isNewEntry);
+        EXPECT_FALSE(addResult.isNewEntry);
         EXPECT_EQ(1, map.get(ptr.get()));
     }
 
@@ -577,7 +577,7 @@
     {
         RefPtr<RefLogger> ptr2(&a);
         auto addResult = map.set(ptr2.release(), 1);
-        EXPECT_EQ(false, addResult.isNewEntry);
+        EXPECT_FALSE(addResult.isNewEntry);
         EXPECT_EQ(1, map.get(ptr.get()));
     }
 
@@ -598,7 +598,7 @@
     {
         RefPtr<RefLogger> ptr2(&a);
         auto addResult = map.set(WTF::move(ptr2), 1);
-        EXPECT_EQ(false, addResult.isNewEntry);
+        EXPECT_FALSE(addResult.isNewEntry);
         EXPECT_EQ(1, map.get(ptr.get()));
     }
 

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes