Title: [174864] trunk/Source
- Revision
- 174864
- Author
- m...@apple.com
- Date
- 2014-10-18 12:04:31 -0700 (Sat, 18 Oct 2014)
Log Message
WorkQueue dispatches functions but isn’t a FunctionDispatcher
https://bugs.webkit.org/show_bug.cgi?id=137853
Reviewed by Anders Carlsson.
Source/WebKit2:
* Platform/WorkQueue.h: Changed to inherit from FunctionDispatcher.
Source/WTF:
* wtf/FunctionDispatcher.h: Added header guards.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (174863 => 174864)
--- trunk/Source/WTF/ChangeLog 2014-10-18 18:13:05 UTC (rev 174863)
+++ trunk/Source/WTF/ChangeLog 2014-10-18 19:04:31 UTC (rev 174864)
@@ -1,3 +1,12 @@
+2014-10-18 Dan Bernstein <m...@apple.com>
+
+ WorkQueue dispatches functions but isn’t a FunctionDispatcher
+ https://bugs.webkit.org/show_bug.cgi?id=137853
+
+ Reviewed by Anders Carlsson.
+
+ * wtf/FunctionDispatcher.h: Added header guards.
+
2014-10-17 Carlos Garcia Campos <cgar...@igalia.com>
[GLIB] Add API to GMainLoopSource to schedule sources after a delay in microseconds
Modified: trunk/Source/WTF/wtf/FunctionDispatcher.h (174863 => 174864)
--- trunk/Source/WTF/wtf/FunctionDispatcher.h 2014-10-18 18:13:05 UTC (rev 174863)
+++ trunk/Source/WTF/wtf/FunctionDispatcher.h 2014-10-18 19:04:31 UTC (rev 174864)
@@ -23,6 +23,9 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
+#ifndef FunctionDispatcher_h
+#define FunctionDispatcher_h
+
#include <functional>
#include <wtf/ThreadSafeRefCounted.h>
@@ -44,3 +47,5 @@
} // namespace WTF
using WTF::FunctionDispatcher;
+
+#endif // FunctionDispatcher_h
Modified: trunk/Source/WebKit2/ChangeLog (174863 => 174864)
--- trunk/Source/WebKit2/ChangeLog 2014-10-18 18:13:05 UTC (rev 174863)
+++ trunk/Source/WebKit2/ChangeLog 2014-10-18 19:04:31 UTC (rev 174864)
@@ -1,3 +1,12 @@
+2014-10-18 Dan Bernstein <m...@apple.com>
+
+ WorkQueue dispatches functions but isn’t a FunctionDispatcher
+ https://bugs.webkit.org/show_bug.cgi?id=137853
+
+ Reviewed by Anders Carlsson.
+
+ * Platform/WorkQueue.h: Changed to inherit from FunctionDispatcher.
+
2014-10-18 Michael Catanzaro <mcatanz...@igalia.com>
[GTK] Improve documentation of webkit_web_view_get_tls_info()
Modified: trunk/Source/WebKit2/Platform/WorkQueue.h (174863 => 174864)
--- trunk/Source/WebKit2/Platform/WorkQueue.h 2014-10-18 18:13:05 UTC (rev 174863)
+++ trunk/Source/WebKit2/Platform/WorkQueue.h 2014-10-18 19:04:31 UTC (rev 174864)
@@ -34,6 +34,7 @@
#include <chrono>
#include <functional>
#include <wtf/Forward.h>
+#include <wtf/FunctionDispatcher.h>
#include <wtf/Functional.h>
#include <wtf/HashMap.h>
#include <wtf/RefCounted.h>
@@ -51,7 +52,7 @@
#include <DispatchQueueEfl.h>
#endif
-class WorkQueue : public ThreadSafeRefCounted<WorkQueue> {
+class WorkQueue final : public FunctionDispatcher {
public:
enum class QOS {
UserInteractive,
@@ -62,9 +63,9 @@
};
static PassRefPtr<WorkQueue> create(const char* name, QOS = QOS::Default);
- ~WorkQueue();
+ virtual ~WorkQueue();
- void dispatch(std::function<void ()>);
+ virtual void dispatch(std::function<void ()>) override;
void dispatchAfter(std::chrono::nanoseconds, std::function<void ()>);
#if OS(DARWIN)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes