Title: [174985] trunk/Source/WebCore
- Revision
- 174985
- Author
- msab...@apple.com
- Date
- 2014-10-21 10:19:49 -0700 (Tue, 21 Oct 2014)
Log Message
Don't create cached functions for HTMLDocument.write*()
https://bugs.webkit.org/show_bug.cgi?id=137906
Reviewed by Darin Adler.
Made it so that JSHTMLDocument::write() and ::writeln() are always created for every prototype.
This is similar to the change in r174847.
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::getOwnPropertySlot):
* html/HTMLDocument.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (174984 => 174985)
--- trunk/Source/WebCore/ChangeLog 2014-10-21 17:05:06 UTC (rev 174984)
+++ trunk/Source/WebCore/ChangeLog 2014-10-21 17:19:49 UTC (rev 174985)
@@ -1,3 +1,17 @@
+2014-10-20 Michael Saboff <msab...@apple.com>
+
+ Don't create cached functions for HTMLDocument.write*()
+ https://bugs.webkit.org/show_bug.cgi?id=137906
+
+ Reviewed by Darin Adler.
+
+ Made it so that JSHTMLDocument::write() and ::writeln() are always created for every prototype.
+ This is similar to the change in r174847.
+
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::JSHTMLDocument::getOwnPropertySlot):
+ * html/HTMLDocument.idl:
+
2014-10-21 Chris Dumez <cdu...@apple.com>
REGRESSION(r174676): It broke the !ENABLE(VIDEO) build
Modified: trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp (174984 => 174985)
--- trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp 2014-10-21 17:05:06 UTC (rev 174984)
+++ trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp 2014-10-21 17:19:49 UTC (rev 174985)
@@ -66,6 +66,14 @@
slot.setCustom(thisObject, ReadOnly | DontDelete | DontEnum, nonCachingStaticFunctionGetter<jsHTMLDocumentPrototypeFunctionOpen, 2>);
return true;
}
+ if (equal(propertyName.publicName(), "write")) {
+ slot.setCustom(thisObject, ReadOnly | DontDelete | DontEnum, nonCachingStaticFunctionGetter<jsHTMLDocumentPrototypeFunctionWrite, 1>);
+ return true;
+ }
+ if (equal(propertyName.publicName(), "writeln")) {
+ slot.setCustom(thisObject, ReadOnly | DontDelete | DontEnum, nonCachingStaticFunctionGetter<jsHTMLDocumentPrototypeFunctionWriteln, 1>);
+ return true;
+ }
if (canGetItemsForName(exec, &thisObject->impl(), propertyName)) {
slot.setCustom(thisObject, ReadOnly | DontDelete | DontEnum, thisObject->nameGetter);
Modified: trunk/Source/WebCore/html/HTMLDocument.idl (174984 => 174985)
--- trunk/Source/WebCore/html/HTMLDocument.idl 2014-10-21 17:05:06 UTC (rev 174984)
+++ trunk/Source/WebCore/html/HTMLDocument.idl 2014-10-21 17:19:49 UTC (rev 174985)
@@ -25,8 +25,8 @@
] interface HTMLDocument : Document {
[Custom, ForwardDeclareInHeader] void open();
void close();
- [Custom] void write([Default=Undefined] optional DOMString text);
- [Custom] void writeln([Default=Undefined] optional DOMString text);
+ [Custom, ForwardDeclareInHeader] void write([Default=Undefined] optional DOMString text);
+ [Custom, ForwardDeclareInHeader] void writeln([Default=Undefined] optional DOMString text);
readonly attribute HTMLCollection embeds;
readonly attribute HTMLCollection plugins;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
